Skip to content

chore: extract/consolidate contributor pr workflow #32494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 35 commits into
base: develop
Choose a base branch
from
Open

chore: extract/consolidate contributor pr workflow #32494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
e66e778
add husky script to build circleci yml files
cacieprins Sep 9, 2025
bf75cda
add circleci cli as a required tool for working with .circleci
cacieprins Sep 9, 2025
b1aeba4
break the original workflows.yml file into separate pieces, using cir…
cacieprins Sep 9, 2025
d7dd504
fix pull request workflow def
cacieprins Sep 10, 2025
2caafba
more robust precommit for circleci packing
cacieprins Sep 10, 2025
7e4285f
even nicer stdout for precommit :)
cacieprins Sep 10, 2025
bdb8194
allow pr pipeline on this branch
cacieprins Sep 10, 2025
79c4d96
split up the config.yml to demonstrate more fully
cacieprins Sep 11, 2025
36895e0
Merge branch 'develop' into use-pack-for-circle
cacieprins Sep 11, 2025
c5c623c
Merge branch 'develop' into use-pack-for-circle
cacieprins Sep 12, 2025
658228f
remove linux-x64-contributor workflow, use contributor workflow to ki…
cacieprins Sep 12, 2025
3684c76
do not run pull-request for contributor prs that have not been approved
cacieprins Sep 12, 2025
07e12e1
use job level continuation
cacieprins Sep 12, 2025
16fed75
try using continuation orb as a job step
cacieprins Sep 12, 2025
5994fbb
move contributor pr approval to the setup config
cacieprins Sep 12, 2025
6a4c5ef
fix parameters
cacieprins Sep 12, 2025
3d9e48e
json?
cacieprins Sep 12, 2025
c69fd34
json?
cacieprins Sep 12, 2025
93414f9
need to check out to be able to pass config path to continuation
cacieprins Sep 12, 2025
a5a9550
use dynamic config to be able to lint etc contributor prs before appr…
cacieprins Sep 12, 2025
6a80e06
maybe if parameter is direct?
cacieprins Sep 12, 2025
0875fe7
debug?
cacieprins Sep 12, 2025
d4401f3
auto-approve contributor gate when launched as an internal pr
cacieprins Sep 12, 2025
e873b0d
vastly simplify, use job filter
cacieprins Sep 12, 2025
56527e4
fix
cacieprins Sep 12, 2025
84d0529
fix conditional on pr pipeline
cacieprins Sep 12, 2025
fa96551
Merge branch 'develop' into use-pack-for-circle
cacieprins Sep 15, 2025
f740cbf
Merge branch 'use-pack-for-circle' into ci/extract-contributor-workflow
cacieprins Sep 15, 2025
6b736e0
Merge branch 'develop' into ci/extract-contributor-workflow
cacieprins Sep 23, 2025
2b598b9
Merge branch 'develop' into ci/extract-contributor-workflow
cacieprins Sep 23, 2025
7f762e8
rm contributor pr flag on build job, use local env var instead
cacieprins Sep 23, 2025
688504e
Merge branch 'develop' into ci/extract-contributor-workflow
cacieprins Sep 25, 2025
655fce9
Merge branch 'develop' into ci/extract-contributor-workflow
cacieprins Oct 2, 2025
4dc8e08
Merge branch 'develop' into ci/extract-contributor-workflow
cacieprins Oct 3, 2025
239b603
does not use context for contrib prs
cacieprins Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .circleci/src/pipeline/@pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1494,9 +1494,6 @@ jobs:
resource_class:
type: string
default: large
is_contributor_pr:
type: boolean
default: false
resource_class: << parameters.resource_class >>
steps:
- restore_cached_workspace
Expand All @@ -1515,8 +1512,9 @@ jobs:
command: yarn list --depth=0 || true
- run:
name: Check env canaries
command: node ./scripts/circle-env.js --check-canaries --is-contributor-pr <<
parameters.is_contributor_pr >>
command: |
IS_CONTRIBUTOR_PR=$([[ "<< pipeline.git.branch >>" =~ ^pull/[0-9]+$ ]] && echo "true" || echo "false")
node ./scripts/circle-env.js --check-canaries --is-contributor-pr $IS_CONTRIBUTOR_PR
- build-and-persist

lint:
Expand Down
Loading
Loading