-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore: extract/consolidate contributor pr workflow #32494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…cleci config pack to compose them into the main workflows.yml file
…ck off pull-request workflow after approval
cypress
|
Project |
cypress
|
Branch Review |
ci/extract-contributor-workflow
|
Run status |
|
Run duration | 19m 40s |
Commit |
|
Committer | Cacie Prins |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
14
|
|
1102
|
|
0
|
|
26665
|
View all changes introduced in this branch ↗︎ |
UI Coverage
45.11%
|
|
---|---|
|
186
|
|
157
|
Accessibility
97.76%
|
|
---|---|
|
4 critical
8 serious
2 moderate
2 minor
|
|
110
|
@cacieprins I created #32574 to test this workflow out and job is running on https://app.circleci.com/pipelines/github/cypress-io/cypress/75143 |
Correct - this is the same pattern as the old |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cacieprins I think the jobs lacking the approval button are automatically locked
it looks to still be automatically locked after clicking approve and the workflow automatically fails
663fdbc
to
655fce9
Compare
@cacieprins I'm running a contributor PR running against the branch https://app.circleci.com/pipelines/github/cypress-io/cypress/75579 |
Additional details
Previously, we had an entirely separate workflow defined for contributor pull requests. This was implemented in order to require maintainer approval for running expensive CI jobs on contributor pull requests.
This consolidates the contributor PR into the primary
pull-request
workflow, while keeping the same behavior.The
node_modules_install
,build
,check-ts
,lint
, andlint-types
jobs will still run for external contributors. Any subsequent jobs require that theapprove-contributor-pr
job be approved by a maintainer. Because theapprove-contributor-pr
job is conditional based on the branch pattern, declaring it as required for subsequent jobs will only be enforced if that job runs - internal contributor/maintainer PRs will not run that job, so it will be skipped as required.Steps to test
Fork this branch to another account, and open a pull request. Verify that it prevents expensive jobs from running prior to approval.
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?Note
Consolidates contributor PR handling into the main pull-request workflow with an approval gate, removes the separate contributor workflow, and infers contributor PR status from branch name during env checks.
linux-x64-contributor
workflow fromworkflows/@main.yml
and folds contributor handling intoworkflows/pull-request.yml
.internal-pr-build
andexternal-pr-build
jobs with branch filters.approve-contributor-pr
approval gate required by expensive/restricted jobs.percy-finalize
,verify-accessibility-results
) to a dedicated finalization section.build
job parameteris_contributor_pr
by deriving it from<< pipeline.git.branch >>
and passing tocircle-env.js
.Written by Cursor Bugbot for commit 239b603. This will update automatically on new commits. Configure here.