Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert changes to build process #27584

Merged
merged 5 commits into from
Aug 18, 2023
Merged

Conversation

astone123
Copy link
Contributor

We've run into some issues after introducing build caching. In the interest of not holding up the v13 release, we should revert these changes. We will re-introduce these changes in the future after the v13 release to improve the build process.

@astone123 astone123 self-assigned this Aug 17, 2023
@cypress
Copy link

cypress bot commented Aug 17, 2023

6 flaky tests on run #50103 ↗︎

0 676 41 0 Flakiness 6

Details:

[run ci]
Project: cypress Commit: 5dee3e1962
Status: Passed Duration: 18:25 💡
Started: Aug 17, 2023 10:51 PM Ended: Aug 17, 2023 11:10 PM
Flakiness  cypress\e2e\top-nav-launchpad.cy.ts • 1 flaky test • launchpad-e2e

View Output Video

Test Artifacts
... > growth prompts appear and call SetPromptShown mutation with the correct payload Output Screenshots Video
Flakiness  cypress\e2e\specs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
... > shows No Specs page with specPattern from config Output Screenshots Video
Flakiness  cypress\e2e\create-from-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
... > Shows create from component card for React projects Output Screenshots Video
Flakiness  cypress\e2e\cypress-in-cypress.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress in Cypress > restarts browser if there is a before:browser:launch task and there is a change on the config Output Screenshots Video
Flakiness  cypress\e2e\specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video

The first 5 flaky specs are shown, see all 6 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windows build is struggling but everything else looks good so I think we can say the cache reversion works. Hoping this change makes its way back in soon with the info we found

@nagash77 nagash77 merged commit 24f1460 into develop Aug 18, 2023
120 of 125 checks passed
@nagash77 nagash77 deleted the astone123/revert-caching branch August 18, 2023 14:05
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 29, 2023

Released in 13.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants