chore: simplify build script #27547
Merged
chore: simplify build script #27547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astone123
commented
Aug 14, 2023
| @@ -185,6 +186,9 @@ | |||
| "{projectRoot}/build" | |||
| ] | |||
| } | |||
| } | |||
| }, | |||
| "implicitDependencies": [ | |||
There was a problem hiding this comment.
This tells Nx that all of the NPM packages need to be built before the CLI is built. We need to do this because the post-build script in CLI copies the built assets for each NPM package into the cli/build folder, so when that happens, all of the packages need to have already been built.
astone123
commented
Aug 14, 2023
| @@ -14,8 +14,7 @@ | |||
| "binary-zip": "node ./scripts/binary.js zip", | |||
| "binary-package": "cross-env NODE_OPTIONS=--max_old_space_size=8192 node ./scripts/binary.js package", | |||
| "check-binary-on-cdn": "node ./scripts/binary.js checkIfBinaryExistsOnCdn", | |||
| "build": "yarn build-npm-modules && lerna run build --stream --no-bail --ignore create-cypress-tests --ignore cypress --ignore \"'@packages/{runner}'\" --ignore \"'@cypress/{angular,react,react18,vue,vue2,mount-utils,svelte}'\" && node ./cli/scripts/post-build.js && lerna run build --stream --scope create-cypress-tests", | |||
| "build-npm-modules": "lerna run build --scope cypress --scope @cypress/mount-utils --scope @cypress/react && lerna run build --scope \"'@cypress/{angular,react18,vue,vue2,svelte}'\"", | |||
| "build": "lerna run build --stream", | |||
There was a problem hiding this comment.
No need to run all of these scripts independently, we can just tell Lerna to build and it will handle the order in which things are built
jordanpowell88
approved these changes
Aug 14, 2023
33 flaky tests on run #49996 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > displays a list of recorded runs if a run has been recorded |
Output
Screenshots
Video
|
|
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Output
Screenshots
Video
|
|
cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution |
Output
Screenshots
Video
|
|
e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| cy.origin - cookie login > general behavior > works in a session |
Output
Video
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| network stubbing > intercepting request > can delay and throttle a StaticResponse |
Output
Video
|
|
The first 5 flaky specs are shown, see all 21 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
AtofStryker
approved these changes
Aug 14, 2023
astone123
commented
Aug 14, 2023
| @@ -1189,10 +1189,6 @@ commands: | |||
| command: | | |||
| source ./scripts/ensure-node.sh | |||
| yarn build --scope cypress | |||
| - run: | |||
There was a problem hiding this comment.
This runs as a postbuild script, so it will run in the previous step. No need to run it again
astone123
commented
Aug 14, 2023
| @@ -1910,7 +1906,7 @@ jobs: | |||
| - restore_cached_workspace | |||
| - run: | |||
| name: Build | |||
| command: yarn lerna run build --scope @cypress/webpack-preprocessor | |||
| command: yarn build --scope @cypress/webpack-preprocessor | |||
There was a problem hiding this comment.
No need to reference Lerna specifically in these scripts, just call yarn build and pass the arguments through.
astone123
added a commit
that referenced
this pull request
Aug 17, 2023
This reverts commit 0a86ec6.
astone123
added a commit
that referenced
this pull request
Aug 17, 2023
* chore: simplify build script * update CI workflows * fix workflows * empty commit because Percy weirdness
nagash77
pushed a commit
that referenced
this pull request
Aug 18, 2023
* Revert "chore: remove Typescript dependency from app node_modules in binary (#27577)" This reverts commit 60d4c83. * Revert "chore: simplify build script (#27547)" This reverts commit 0a86ec6. * Revert "chore: upgrade lerna to 6, cache build step (#26913)" This reverts commit 9e60aeb. * build everything * [run ci]
astone123
added a commit
that referenced
this pull request
Aug 18, 2023
This reverts commit 0a86ec6.
astone123
added a commit
that referenced
this pull request
Aug 18, 2023
* chore: simplify build script * update CI workflows * fix workflows * empty commit because Percy weirdness
astone123
added a commit
that referenced
this pull request
Aug 21, 2023
This reverts commit 0a86ec6.
astone123
added a commit
that referenced
this pull request
Aug 21, 2023
* chore: simplify build script * update CI workflows * fix workflows * empty commit because Percy weirdness
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now our build script runs three different Lerna commands to make sure that packages are built in the correct order. We don't need to do this anymore because we can specify which packages depend on which other packages to ensure that they build in the correct order.
This PR updates our
buildscript to just runlerna run build, which builds all of the packages in the repo, relying on the dependency graph in order to know which packages need to be built in which order.