Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move non spec files on migration #21054

Merged

Conversation

estrada9166
Copy link
Member

@estrada9166 estrada9166 commented Apr 12, 2022

User facing changelog

Additional details

When we were migrating the specs, we were removing the non spec files on the integration folder. So, after moving the spec files, we want to copy, the remaining files on the integration folder into the e2e folder

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 12, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Apr 12, 2022



Test summary

4343 0 48 0Flakiness 1


Run details

Project cypress
Status Passed
Commit df36f29
Started Apr 14, 2022 7:25 PM
Ended Apr 14, 2022 7:39 PM
Duration 13:27 💡
OS Linux Debian - 10.10
Browser Electron 94

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/commands/files.cy.js Flakiness
1 ... > has implicit existence assertion, retries and throws a specific error when file does not exist for null encoding

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@estrada9166 estrada9166 marked this pull request as ready for review April 13, 2022 02:47
@estrada9166 estrada9166 requested review from a team and tgriesser as code owners April 13, 2022 02:47
@estrada9166 estrada9166 requested review from jennifer-shehane, emilyrohrbough and lmiller1990 and removed request for a team, tgriesser and jennifer-shehane April 13, 2022 02:47
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@estrada9166 estrada9166 merged commit e7d79ee into 10.0-release Apr 14, 2022
@estrada9166 estrada9166 deleted the alejandro/fix/move-non-spec-files-on-migration branch April 14, 2022 19:36
tgriesser added a commit that referenced this pull request Apr 20, 2022
…e-config

* 10.0-release:
  fix: make error on integration folder point to e2e (#20853)
  fix(unify): Update Cypress Dashboard Service Link in Login Modal (#21084)
  chore: fix windows node_modules install step (#21098)
  fix: webpack integration tests for app w webpack-dev-server-fresh (#21093)
  fix: move non spec files on migration (#21054)
  Bumping electron version in root
  chore(deps): Bumping electron dependency to 15.5.1 (#21072)
  fix: resolves correctly specPattern (#21057)
  feat: replace reconfigure button on settings page with link to config doc (#21077)
  feat(launchpad): update CT setup and config scaffolding (#20893)
  fix: cy.type('{enter}') on <input> elements submits the form correctly after Firefox 98. (#21042)
  chore: making the npm deps for vue, react, and vue2 use 0.0.0-dev (#21081)
  fix(cli): show additional mitigation steps for max path length error (#21047)
  fix: Plugin error when sending on disconnected IPC channel (#21011)
  chore: add internal types for cy.session command (#21028)
  chore: Update Chrome (stable) to 100.0.4896.88 (#21043)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants