-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Plugin error when sending on disconnected IPC channel #21011
Conversation
Thanks for taking the time to open a PR!
|
I have added a test case for the new behaviour (similar to the test for killed processes). However, Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomudding There's a failing test in the test file you touched, could you look at the failure to see if this is related? Thanks.
Yes I am aware, the reason is that the |
Dismissing my previous review so that other reviewers can look at this.
Yeah, adding it to the mocked process object seems correct. Looks good to me, just rerunning the flaky test so we can get everything green. |
These bogus error messages when cancelling tests have bothered me, but never enough to take the time to fix it - thanks for taking the time! |
…e-config * 10.0-release: fix: make error on integration folder point to e2e (#20853) fix(unify): Update Cypress Dashboard Service Link in Login Modal (#21084) chore: fix windows node_modules install step (#21098) fix: webpack integration tests for app w webpack-dev-server-fresh (#21093) fix: move non spec files on migration (#21054) Bumping electron version in root chore(deps): Bumping electron dependency to 15.5.1 (#21072) fix: resolves correctly specPattern (#21057) feat: replace reconfigure button on settings page with link to config doc (#21077) feat(launchpad): update CT setup and config scaffolding (#20893) fix: cy.type('{enter}') on <input> elements submits the form correctly after Firefox 98. (#21042) chore: making the npm deps for vue, react, and vue2 use 0.0.0-dev (#21081) fix(cli): show additional mitigation steps for max path length error (#21047) fix: Plugin error when sending on disconnected IPC channel (#21011) chore: add internal types for cy.session command (#21028) chore: Update Chrome (stable) to 100.0.4896.88 (#21043)
file:preprocessor
child process with disconnected IPC channel duringpreprocessor:close
causes unclear plugin error #21010User facing changelog
Fixed an issue where an ambiguous error message was incorrectly shown to the user when Cypress was interrupted during an active test. Fixed #21010.
Additional details
Interrupting Cypress during an active test would cause the
file:preprocessor
child process' IPC channel to already be disconnected while handlingpreprocessor:close
. This would lead to an error as it is no longer possibly to send message. That could cause confusion due to the ambiguous error message produced.This fix check that the process is still connected before sending messages on the IPC channel.
How has the user experience changed?
No more ambiguous error when interrupting the Cypress process.
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?