-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: (multi-domain) support origin and domain name in switchToDomain #20564
Merged
mschile
merged 4 commits into
feature-multidomain
from
issue-19901-multi-domain-origin-and-domain
Mar 14, 2022
Merged
chore: (multi-domain) support origin and domain name in switchToDomain #20564
mschile
merged 4 commits into
feature-multidomain
from
issue-19901-multi-domain-origin-and-domain
Mar 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for taking the time to open a PR!
|
mschile
requested review from
AtofStryker,
mjhenkes and
chrisbreiding
and removed request for
jennifer-shehane
March 10, 2022 18:56
mschile
changed the title
feat: support origin and domain name in switchToDomain
chore: (multi-domain) support origin and domain name in switchToDomain
Mar 10, 2022
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
AtofStryker
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chrisbreiding
approved these changes
Mar 14, 2022
AtofStryker
added a commit
that referenced
this pull request
Mar 14, 2022
AtofStryker
added a commit
that referenced
this pull request
Mar 14, 2022
* Refactor error serialization to rely on structuredClone over clone and other means. * add system test to verify stack trace is corrected for multi-domain errors * remove redundant code and update documentation/tests * address comments from code review * remove 'to map' from serialization error message * make all errors truthy before emitting through spec bridge to prevent sending unecessary values through postMessage * fix falsy error serialization in firefox * move reify errors into the primaryDomainCommunicator * address comment made in review #20520 (comment) * update switchToDomain to contain fully qualified URL to be compatible with #20564
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
n/a
Additional details
Users are currently only able to setup the spec bridge using the domain name. The prevents them from specifying a protocol (http vs https) and from specifying a specific port. This change allows users to provide an origin or a domain name.
Note: the messaging is still assuming a single domain so while this change allows an origin to be passed, only one spec bridge for a particular domain will be created.
switchToDomain
command to accept an origin or domainhttps
is assumedfoobar.com
->https://foobar.com
window.specBridgeDomain
as unicode domains no longer need itswitchToDomain
calls to use originhttps://foobar.com:3500
instead of justfoobar.com
Supported:
Not currently supported:
Not supported:
How has the user experience changed?
Users are now able to pass an origin or domain into
switchToDomain
.PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?