Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add variables to res.local to determine if multi-domain has a registered #20552

Conversation

AtofStryker
Copy link
Contributor

callback, and if so, inject multi-domain. Also added more specific error that likely overlaps with 19900

  • Closes

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

callback, and if so, inject multi-domain. Also added more specific error that likely overlaps with 19900
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 9, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Mar 9, 2022



Test summary

20105 17 310 156Flakiness 4


Run details

Project cypress
Status Failed
Commit d0a30b6
Started Mar 9, 2022 8:40 PM
Ended Mar 9, 2022 8:53 PM
Duration 13:41 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Failures

Run group: 5x-driver-electron (Linux, Electron )
commands/net_stubbing_spec.ts Failed
1 network stubbing > intercepting request > should delay the same amount on every response
e2e/multi-domain/commands/multi_domain_navigation.spec.ts Failed
1 multi-domain navigation > .go()
e2e/multi-domain/commands/multi_domain_actions.spec.ts Failed
1 multi-domain actions > .submit()
e2e/multi-domain/navigation_spec.ts Failed
1 navigation events > window:load > reloads
e2e/multi-domain/multi_domain_events_spec.ts Failed
1 multi-domain > post window load events > form:submitted
Run group: 5x-driver-firefox (Linux, Firefox )
e2e/multi-domain/commands/multi_domain_navigation.spec.ts Failed
1 multi-domain navigation > .go()
e2e/multi-domain/navigation_spec.ts Failed
1 navigation events > window:load > reloads
e2e/multi-domain/commands/multi_domain_actions.spec.ts Failed
1 multi-domain actions > .submit()
e2e/multi-domain/multi_domain_events_spec.ts Failed
1 multi-domain > post window load events > form:submitted
Run group: 5x-driver-chrome:beta (Linux, Chrome beta )
e2e/multi-domain/commands/multi_domain_navigation.spec.ts Failed
1 multi-domain navigation > .go()
e2e/multi-domain/navigation_spec.ts Failed
1 navigation events > window:load > reloads
e2e/multi-domain/multi_domain_events_spec.ts Failed
1 multi-domain > post window load events > form:submitted
e2e/multi-domain/commands/multi_domain_actions.spec.ts Failed
1 multi-domain actions > .submit()
Run group: 5x-driver-chrome (Linux, Chrome )
e2e/multi-domain/commands/multi_domain_navigation.spec.ts Failed
1 multi-domain navigation > .go()
e2e/multi-domain/navigation_spec.ts Failed
1 navigation events > window:load > reloads
e2e/multi-domain/multi_domain_events_spec.ts Failed
1 multi-domain > post window load events > form:submitted
e2e/multi-domain/commands/multi_domain_actions.spec.ts Failed
1 multi-domain actions > .submit()

Flakiness

commands/net_stubbing_spec.ts Flakiness
1 network stubbing > intercepting response > can 'delay' a proxy response using Promise.delay
2 network stubbing > waiting and aliasing > can timeout incrementally waiting on requests
3 network stubbing > intercepting response > can 'delay' a proxy response using Promise.delay
cypress/proxy-logging_spec.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@AtofStryker
Copy link
Contributor Author

closing in favor of #20752

@AtofStryker AtofStryker deleted the issue_19632_only_inject_multi_domain_when_needed branch March 25, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant