-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: (multi-domain) adding support for cy.visit in multi-domain #20467
feat: (multi-domain) adding support for cy.visit in multi-domain #20467
Conversation
Thanks for taking the time to open a PR!
|
packages/driver/cypress/integration/e2e/multi-domain/commands/multi_domain_misc.spec.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Besides the few nitpicks, it looks there are some legitimately failing tests that need to be looked into.
packages/driver/cypress/integration/e2e/multi-domain/commands/multi_domain_misc.spec.ts
Outdated
Show resolved
Hide resolved
packages/driver/cypress/integration/e2e/multi-domain/commands/multi_domain_misc.spec.ts
Outdated
Show resolved
Hide resolved
packages/driver/cypress/integration/e2e/multi-domain/commands/multi_domain_misc.spec.ts
Outdated
Show resolved
Hide resolved
packages/driver/cypress/integration/e2e/multi-domain/commands/multi_domain_navigation.spec.ts
Show resolved
Hide resolved
packages/driver/cypress/integration/e2e/multi-domain/multi_domain_cypress_api.spec.ts
Show resolved
Hide resolved
packages/driver/cypress/integration/e2e/multi-domain/multi_domain_uncaught_errors_spec.ts
Show resolved
Hide resolved
Test summaryRun details
View run in Cypress Dashboard ➡️ FlakinessThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've made this look easy :)
User facing changelog
n/a
Additional details
This change supports the following:
cy.visit()
withinswitchToDomain
both as the first navigation to a new domain or navigating within the domaincy.go()
withinswitchToDomain
Details:
$autIframe
isMultiDomain
value is passed along to:fullMultiDomain
for buffered multi-domain responseshasVisitedAboutBlank
is sync'd between primary and secondary to ensureabout:blank
is only visited once for the specHow has the user experience changed?
Users are now able to use
cy.visit()
withinswitchToDomain
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?