Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hockey positions #505

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Update hockey positions #505

merged 3 commits into from
Dec 1, 2023

Commits on Nov 21, 2023

  1. Update hockey\constant.py 

    Add descriptions for all positions, correct previous position shift for forwards.
    @samthom1
    samthom1 authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    3922a29 View commit details
    Browse the repository at this point in the history

  2. Update player.py 

    Shift position & lineupSlot lookups by one to account for incongruency with the position keys in the eligibleSlots field.
    @samthom1
    samthom1 authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    7f52448 View commit details
    Browse the repository at this point in the history

  3. Correction player.py 

    Correction on lineupSlot, keys are the same as eligibleSlots
    @samthom1
    samthom1 authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    018747d View commit details
    Browse the repository at this point in the history