Update hockey positions #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add descriptions for all positions, correct previous position shift for forwards.
Shift position & lineupSlot lookups by one to account for incongruency with the position keys in the eligibleSlots field.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #505 +/- ##
=======================================
Coverage 80.53% 80.53%
=======================================
Files 59 59
Lines 2106 2106
=======================================
Hits 1696 1696
Misses 410 410 ☔ View full report in Codecov by Sentry. |
Correction on lineupSlot, keys are the same as eligibleSlots
|
Wow this is interesting, I wonder why ESPN just didn't use the same ids. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hockey positions don't hold the same key:value relationship between the
eligibleSlotsandlineupSlotfields and thepositionfield under player.py.Modified constant.py to match the
eligibleSlotsandlineupSlotvalues (which has an extra 'Forward' value) and reconfigured the Player() init to account for the mismatch in keys.