Remove useless Pylint disables

documentation/docbuild/make.py

@@ -128,12 +128,12 @@ def runSphinx(self):
 
         if sphinx_new:
             # noinspection PyPackageRequirements
-            import sphinx.cmd.build  # pylint: disable=import-error
+            import sphinx.cmd.build
             sphinx_main_command = sphinx.cmd.build.main
         else:
             sphinx_main_command = sphinx.main  # pylint: disable=no-member
 
-        try:  # pylint: disable=assignment-from-no-return
+        try:
             returnCode = sphinx_main_command(sphinxOptions)
         except SystemExit:
             returnCode = 0

documentation/nbvalNotebook.py

@@ -13,9 +13,9 @@
 import subprocess
 
 # noinspection PyPackageRequirements
-import pytest  # pylint: disable=unused-import,import-error
+import pytest  # pylint: disable=unused-import
 # noinspection PyPackageRequirements
-import nbval  # pylint: disable=unused-import,import-error
+import nbval  # pylint: disable=unused-import
 
 from music21 import environment
 from music21 import common

documentation/testDocumentation.py

@@ -23,9 +23,9 @@
 import time
 
 # noinspection PyPackageRequirements
-from docutils.core import publish_doctree  # pylint: disable=import-error
+from docutils.core import publish_doctree
 # noinspection PyPackageRequirements
-import docutils.nodes  # pylint: disable=import-error
+import docutils.nodes
 
 
 import nbvalNotebook  # TODO: make into a package and import with .nbvalNotebook

music21/abcFormat/__init__.py

@@ -1685,7 +1685,7 @@ def getQuarterLength(self,
             ql = activeDefaultQuarterLength * int(numStr)
 
         if self.brokenRhythmMarker is not None:
-            symbol, direction = self.brokenRhythmMarker  # pylint: disable=unpacking-non-sequence
+            symbol, direction = self.brokenRhythmMarker
             if symbol == '>':
                 modPair = (1.5, 0.5)
             elif symbol == '<':

music21/abcFormat/testFiles.py

@@ -9,10 +9,6 @@
 
 import unittest
 
-# some lines must be this long, because of sources.
-# pylint: disable=line-too-long
-
-
 # abc standard
 # http://abcnotation.com/abc2mtex/abc.txt
 from music21 import environment

music21/audioSearch/__init__.py

@@ -154,7 +154,7 @@ def autocorrelationFunction(recordedSignal, recordSampleRateIn):
     correlation = correlation[lengthCorrelation:]
     difference = numpy.diff(correlation)  # Calculates the difference between slots
     positiveDifferences = numpy.where(difference > 0)[0]
-    if len(positiveDifferences) == 0:  # pylint: disable=len-as-condition
+    if len(positiveDifferences) == 0:
         finalResult = 10  # Rest
     else:
         beginning = positiveDifferences[0]

music21/base.py

@@ -61,7 +61,7 @@
 from music21 import exceptions21
 from music21 import prebase
 from music21.sites import Sites, SitesException, WEAKREF_ACTIVE
-from music21.style import Style  # pylint: disable=unused-import
+from music21.style import Style
 from music21.sorting import SortTuple, ZeroSortTupleLow, ZeroSortTupleHigh
 # needed for temporal manipulations; not music21 objects
 from music21 import tie
@@ -165,7 +165,7 @@ def __new__(cls, tupEls):
         # noinspection PyTypeChecker
         return super(_SplitTuple, cls).__new__(cls, tuple(tupEls))
 
-    def __init__(self, tupEls):  # pylint: disable=super-init-not-called
+    def __init__(self, tupEls):
         self.spannerList = []
 
 # -----------------------------------------------------------------------------
@@ -673,7 +673,7 @@ def __getstate__(self) -> dict[str, t.Any]:
 
     def __setstate__(self, state: dict[str, t.Any]):
         # defining self.__dict__ upon initialization currently breaks everything
-        object.__setattr__(self, '__dict__', state)  # pylint: disable=attribute-defined-outside-init
+        object.__setattr__(self, '__dict__', state)
 
     def _reprInternal(self) -> str:
         '''
@@ -3200,7 +3200,7 @@ def splitAtQuarterLength(
         for listType in ('expressions', 'articulations'):
             if hasattr(e, listType):
                 temp = getattr(e, listType)
-                setattr(e, listType, [])  # pylint: disable=attribute-defined-outside-init
+                setattr(e, listType, [])
                 setattr(eRemain, listType, [])
                 for thisExpression in temp:  # using thisExpression as a shortcut for expr or art.
                     if hasattr(thisExpression, 'splitClient'):  # special method (see Trill)

music21/chord/__init__.py

@@ -177,7 +177,7 @@ def __deepcopy__(self: _ChordBaseType, memo=None) -> _ChordBaseType:
         # after copying, if a Volume exists, it is linked to the old object
         # look at _volume so as not to create object if not already there
         # noinspection PyProtectedMember
-        for n in new._notes:  # pylint: disable=no-member
+        for n in new._notes:
             n._chordAttached = new
             # if .volume is called, a new Volume obj will be created
             if n.hasVolumeInformation():

music21/common/__init__.py

@@ -40,7 +40,6 @@
 
 from music21 import defaults
 from music21 import exceptions21
-# pylint: disable=wildcard-import
 from music21.common.classTools import *  # including isNum, isListLike
 from music21.common.decorators import *  # gives the deprecated decorator
 from music21.common.enums import *

music21/common/enums.py

@@ -74,8 +74,6 @@ def is_bool_tuple(v):
         else:
             return False
 
-    # pylint having Enum problems with classes as usual.
-    # pylint: disable=comparison-with-callable
     def __eq__(self, other):
         if isinstance(other, self.__class__):
             return super().__eq__(other)

music21/common/fileTools.py

@@ -65,7 +65,7 @@ def readPickleGzip(filePath: str | pathlib.Path) -> t.Any:
         try:
             uncompressed = pickledFile.read()
             newMdb = pickle.loads(uncompressed)
-        except Exception as e:  # pylint: disable=broad-exception-caught
+        except Exception as e:
             # pickle exceptions cannot be caught directly
             # because they might come from pickle or _pickle and the latter cannot
             # be caught.

music21/common/parallel.py

@@ -104,8 +104,6 @@ def runParallel(iterable, parallelFunction, *,
     >>> outputs
     [99, 11, 123]
     '''
-    # multiprocessing has trouble with introspection
-    # pylint: disable=not-callable
     numCpus = cpus()
 
     if numCpus == 1 or multiprocessing.current_process().daemon:

music21/common/types.py

@@ -17,7 +17,7 @@
 from music21.common.enums import OffsetSpecial
 
 if t.TYPE_CHECKING:
-    import music21  # pylint: disable=unused-import
+    import music21
 
 DocOrder = list[str | Callable]
 OffsetQL = float | Fraction

music21/configure.py

@@ -546,10 +546,10 @@ def performAction(self, simulate=False):
         else:
             try:
                 self._performAction(simulate=simulate)
-            except DialogException:  # pylint: disable=catching-non-exception
+            except DialogException:
                 # in some cases, the action selected requires exciting the
                 # configuration assistant
-                # pylint: disable=raising-non-exception,raise-missing-from
+                # pylint: disable=raise-missing-from
                 raise DialogException('perform action raised a dialog exception')
 
 

music21/converter/subConverters.py

@@ -1427,7 +1427,7 @@ def testImportMei3(self):
         it was exported from
         the "sibmei" plug-in for Sibelius).
         '''
-        from unittest import mock  # pylint: disable=no-name-in-module
+        from unittest import mock
         with mock.patch('music21.mei.MeiToM21Converter') as mockConv:
             testPath = common.getSourceFilePath() / 'mei' / 'test' / 'notes_in_utf16.mei'
             testConverter = ConverterMEI()
@@ -1438,7 +1438,7 @@ def testImportMei4(self):
         '''
         For the sake of completeness, this is the same as testImportMei3() but with a UTF-8 file.
         '''
-        from unittest import mock  # pylint: disable=no-name-in-module
+        from unittest import mock
         with mock.patch('music21.mei.MeiToM21Converter') as mockConv:
             testPath = common.getSourceFilePath() / 'mei' / 'test' / 'notes_in_utf8.mei'
             testConverter = ConverterMEI()

music21/corpus/corpora.py

@@ -742,7 +742,7 @@ def __init__(self, name: str | None = None):
             self._name = None
         elif name in ('core', 'virtual'):
             raise CorpusException(f'The name {name!r} is reserved.')
-        else:  # pylint: disable=no-else-raise  # false positive.
+        else:
             self._name = name
 
     # SPECIAL METHODS #

music21/environment.py

@@ -49,7 +49,7 @@ def etIndent(elem, level=0, spaces=2):
     indent an elementTree element for printing
     '''
     i = '\n' + level * spaces * ' '
-    if len(elem):  # pylint: disable=len-as-condition
+    if len(elem):
         if not elem.text or not elem.text.strip():
             elem.text = i + spaces * ' '
         if not elem.tail or not elem.tail.strip():

music21/exceptions21.py

@@ -35,7 +35,7 @@ class StreamException(Music21Exception):
     pass
 
 class ImmutableStreamException(StreamException):
-    def __init__(self, msg='An immutable Stream cannot be changed'):  # pylint: disable=useless-super-delegation
+    def __init__(self, msg='An immutable Stream cannot be changed'):
         super().__init__(msg)
 
 

music21/features/__init__.py

@@ -12,15 +12,13 @@
 
 __all__ = ['base', 'outputFormats', 'jSymbolic', 'native']
 
-# __init__ can wildcard import base; it's how it is designed.
-from music21.features.base import *  # pylint: disable=wildcard-import
+from music21.features.base import *
 
 from music21.features import base
 from music21.features import outputFormats
 
 from music21.features import jSymbolic
 from music21.features import native
 
-# pylint: disable=redefined-builtin
 __doc__ = base.__doc__
 

music21/graph/plot.py

@@ -891,7 +891,7 @@ def processor(self):
         if not self.processorClass:
             return None
         if not self._processor:
-            self._processor = self.processorClass(self.streamObj)  # pylint: disable=not-callable
+            self._processor = self.processorClass(self.streamObj)
         return self._processor
 
     def run(self, *, callProcess: bool = True, **keywords):

music21/humdrum/spineParser.py

@@ -1277,7 +1277,6 @@ def parse(self):
             elif eventC.startswith('!'):
                 thisObject = SpineComment(eventC)
             else:
-                # pylint: disable=attribute-defined-outside-init
                 thisObject = base.ElementWrapper(event)
                 thisObject.humdrumPosition = event.position
 
@@ -1335,7 +1334,6 @@ def parse(self):
                     thisObject = self.processNoteEvent(eventC)
 
                 if thisObject is not None:
-                    # pylint: disable=attribute-defined-outside-init
                     thisObject.humdrumPosition = event.position
                     thisObject.priority = event.position
                     self.stream.coreAppend(thisObject)

music21/interval.py

@@ -3676,7 +3676,7 @@ def noteStart(self) -> music21.note.Note | None:
         if p and p._client:
             return p._client
         elif p:
-            from music21 import note  # pylint: disable=redefined-outer-name
+            from music21 import note
             return note.Note(pitch=p)
 
     @noteStart.setter
@@ -3696,7 +3696,7 @@ def noteEnd(self) -> music21.note.Note | None:
         if p and p._client:
             return p._client
         elif p:
-            from music21 import note  # pylint: disable=redefined-outer-name
+            from music21 import note
             return note.Note(pitch=p)
 
     @noteEnd.setter

music21/lily/lilyObjects.py

@@ -8,8 +8,6 @@
 # Copyright:    Copyright © 2007-2012 Michael Scott Asato Cuthbert
 # License:      BSD, see license.txt
 # ------------------------------------------------------------------------------
-# pylint: disable=too-many-function-args
-# unfortunately the way this was originally set up the previous line is needed
 '''
 music21 translates to Lilypond format and if Lilypond is installed on the
 local computer, can automatically generate .pdf, .png, and .svg versions
@@ -2265,7 +2263,6 @@ def testOneNoteTheHardWay(self):
 
 
 if __name__ == '__main__':
-    # pylint: disable=ungrouped-imports
     import music21
     music21.mainTest(Test)
 

music21/lily/translate.py

@@ -2667,7 +2667,6 @@ def testStaffLines(self):
 
 # ------------------------------------------------------------------------------
 if __name__ == '__main__':
-    # pylint: disable=ungrouped-imports
     import music21
     music21.mainTest(Test)  # , TestExternal)
     # music21.mainTest(TestExternal, 'noDocTest')

music21/mei/base.py

@@ -309,7 +309,7 @@ def __init__(self, theDocument=None):
             if isinstance(self.documentRoot, ElementTree):
                 # pylint warns that :class:`Element` doesn't have a getroot() method, which is
                 # true enough, but...
-                self.documentRoot = self.documentRoot.getroot()  # pylint: disable=maybe-no-member
+                self.documentRoot = self.documentRoot.getroot()
 
             if f'{MEI_NS}mei' != self.documentRoot.tag:
                 raise MeiElementError(_WRONG_ROOT_ELEMENT.format(self.documentRoot.tag))
@@ -419,7 +419,7 @@ def makeDuration(
     0.5
     '''
     returnDuration = duration.Duration(base)
-    returnDuration.dots = dots  # pylint: disable=assigning-non-slot
+    returnDuration.dots = dots
     return returnDuration
 
 
@@ -1521,7 +1521,7 @@ def _guessTuplets(theLayer):
 
 # Element-Based Converter Functions
 # -----------------------------------------------------------------------------
-def scoreDefFromElement(elem, slurBundle=None):  # pylint: disable=unused-argument
+def scoreDefFromElement(elem, slurBundle=None):
     '''
     <scoreDef> Container for score meta-information.
 
@@ -1694,7 +1694,7 @@ def staffGrpFromElement(elem, slurBundle=None, staffDefDict=None):
     return staffDefDict
 
 
-def staffDefFromElement(elem, slurBundle=None):  # pylint: disable=unused-argument
+def staffDefFromElement(elem, slurBundle=None):
     '''
     <staffDef> Container for staff meta-information.
 

music21/mei/test_base.py

@@ -22,11 +22,6 @@
 # if we mock many things, this may be triggered
 # pylint: disable=too-many-arguments
 
-# pylint is bad at guessing types in these tests---reasonably so
-# pylint: disable=maybe-no-member
-
-# pylint: disable=ungrouped-imports
-# pylint: disable=import-error
 import unittest
 
 # To have working MagicMock objects, we can't use cElementTree even though it would be faster.
@@ -36,7 +31,7 @@
 
 from collections import defaultdict
 from fractions import Fraction
-from unittest import mock  # pylint: disable=no-name-in-module
+from unittest import mock
 
 from music21 import articulations
 from music21 import bar

music21/metadata/__init__.py

@@ -2420,7 +2420,6 @@ def _convertValue(uniqueName: str, value: t.Any) -> ValueType:
 
         if valueType is int:
             # noinspection PyBroadException
-            # pylint: disable=bare-except
             try:
                 return int(value)
             except:

music21/metadata/caching.py

@@ -377,7 +377,7 @@ def process_serial(jobs):
 # -----------------------------------------------------------------------------
 
 
-class WorkerProcess(multiprocessing.Process):  # pylint: disable=inherit-non-class
+class WorkerProcess(multiprocessing.Process):
     '''
     A worker process for use by the multithreaded metadata-caching job
     processor.

music21/metadata/primitives.py

@@ -399,7 +399,6 @@ def datetime(self):
         Traceback (most recent call last):
         TypeError: ...argument 'day' (pos 3)...
         '''
-        # pylint: disable=no-value-for-parameter
         post = []
         # order here is order for datetime
         # TODO: need defaults for incomplete times.

music21/midi/__init__.py

@@ -352,8 +352,7 @@ def __repr__(self):
 
     @classmethod
     def hasValue(cls, val):
-        # https://github.com/PyCQA/pylint/issues/3941
-        return val in cls._value2member_map_  # pylint: disable=no-member
+        return val in cls._value2member_map_
 
 
 class ChannelVoiceMessages(_ContainsEnum):

music21/musicxml/m21ToXml.py

@@ -6959,7 +6959,6 @@ def setMxAttributesObjectForStartOfMeasure(self):
         if mxMeasureStyle is not None:
             mxAttributes.append(mxMeasureStyle)
 
-        # pylint: disable=len-as-condition
         if len(mxAttributes) > 0 or mxAttributes.attrib:
             self.xmlRoot.append(mxAttributes)
         return mxAttributes