Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless Pylint disables #1615

Merged

Conversation

jacobtylerwalls
Copy link
Member

Not the most substantial PR, but it's nice to remove useless pylint disables every once in a while.

Found this with the --enable=useless-suppression argument.

@coveralls
Copy link

coveralls commented Jun 23, 2023

Coverage Status

Changes unknown when pulling 5d9142d on jacobtylerwalls:useless-suppression-2 into ** on cuthbertLab:master**.

@mscuthbert
Copy link
Member

Thank you! :-) These were all former bug-fixes that now just work!

mypy failure is unrelated; from a recent upgrade. #1616 got hit by it too and fixes the problem. Will re-run tests and merge this once #1616 is in.

@mscuthbert mscuthbert closed this Jun 26, 2023
@mscuthbert mscuthbert reopened this Jun 26, 2023
@mscuthbert mscuthbert merged commit f771fa7 into cuthbertLab:master Jun 26, 2023
@jacobtylerwalls jacobtylerwalls deleted the useless-suppression-2 branch June 26, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants