Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dismiss keyboard on showing in app message on CDP SDK #828

Merged
merged 2 commits into from
Oct 25, 2024
Merged

fix: dismiss keyboard on showing in app message on CDP SDK #828

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
277a3e2
fix to dismiss keyboard on showing in app message
ami-aman Oct 16, 2024
eac715c
thread util
ami-aman Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Sources/MessagingInApp/Gist/GistDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,13 @@ class GistDelegateImpl: GistDelegate {
if let deliveryId = message.campaignDeliveryId {
eventBusHandler.postEvent(TrackInAppMetricEvent(deliveryID: deliveryId, event: InAppMetric.opened.rawValue))
}

// To ensure the keyboard is dismissed on displaying an in-app message,
// Update UI on main thread only.
// Dismiss keyboard on showing the message to prevent gap between
// displaying the in-app message and dismissing the keyboard.
DispatchQueue.main.async {
UIApplication.shared.sendAction(#selector(UIResponder.resignFirstResponder), to: nil, from: nil, for: nil)
}
eventListener?.messageShown(message: InAppMessage(gistMessage: message))
}

Expand Down
Loading