fix: dismiss keyboard on showing in app message on CDP SDK #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #828 +/- ##
==========================================
+ Coverage 63.68% 64.55% +0.87%
==========================================
Files 140 149 +9
Lines 5502 6168 +666
==========================================
+ Hits 3504 3982 +478
- Misses 1998 2186 +188 ☔ View full report in Codecov by Sentry. |
SDK binary size reports 📊SDK binary size of this PRSDK binary size diff report between this PR and the main branch |
Shahroz16
reviewed
Oct 21, 2024
Shahroz16
approved these changes
Oct 22, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
## [3.5.1](3.5.0...3.5.1) (2024-10-25) ### Bug Fixes * dismiss keyboard on showing in app message on CDP SDK ([#828](#828)) ([faad28a](faad28a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This behavior prevents interaction with the app, as displaying of the in-app message disrupts the current activity (e.g., typing or moving back to previous screen) and makes it difficult for the user to manage actions.
Solution
Dismiss keyboard when in-app message shows up on the screen.
Testing
The change has been tested on :
Video
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2024-10-16.at.18.08.45.mp4