Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only superusers update embargos #2116

Merged
merged 8 commits into from
Apr 17, 2021
Merged

Only superusers update embargos #2116

merged 8 commits into from
Apr 17, 2021

Commits on Mar 8, 2021

  1. WIP failing tests updating embargos

    @maxkadel
    maxkadel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    3ff5aa2 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Silence some warnings including URI.escape/unescape 

    Also some style checker changes
    @fnibbit
    fnibbit committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    1e0f721 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. admin_dashboard_spec green, 

    - embargo_edit_spec only failing on last line of test on :76
- comments on current ability
    @maxkadel
    maxkadel committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    2f0141b View commit details
    Browse the repository at this point in the history

  2. admin dashboard and embargo edit tests green, 

    - overriding entire embargo_controller_behavior.rb
    @maxkadel
    maxkadel committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    36bec49 View commit details
    Browse the repository at this point in the history

  3. Only override the edit behavior for embargoes controller

    @maxkadel
    maxkadel committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    037d741 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. Check for breadcrumbs

    @fnibbit
    fnibbit committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    e9ab0d4 View commit details
    Browse the repository at this point in the history

  2. Override edit method in controller rather than behavior

    @fnibbit
    fnibbit committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    7719f04 View commit details
    Browse the repository at this point in the history

  3. Remove testing changes

    @fnibbit
    fnibbit committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    95aa5d4 View commit details
    Browse the repository at this point in the history