Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only superusers update embargos #2116

Merged
merged 8 commits into from
Apr 17, 2021
Merged

Only superusers update embargos #2116

merged 8 commits into from
Apr 17, 2021

Conversation

maxkadel
Copy link
Contributor

No description provided.

maxkadel and others added 5 commits March 8, 2021 09:37
@maxkadel
WIP failing tests updating embargos
3ff5aa2
@fnibbit
Silence some warnings including URI.escape/unescape
1e0f721 
Also some style checker changes
@maxkadel
admin_dashboard_spec green,
2f0141b 
- embargo_edit_spec only failing on last line of test on :76
- comments on current ability
@maxkadel
admin dashboard and embargo edit tests green,
36bec49 
- overriding entire embargo_controller_behavior.rb
@maxkadel
Only override the edit behavior for embargoes controller
037d741
@coveralls
Copy link

coveralls commented Mar 11, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.009%) to 92.119% when pulling 95aa5d4 on only_superusers_update_embargos into 82d1fac on main.

@mark-dce mark-dce marked this pull request as ready for review April 17, 2021 22:18
@mark-dce mark-dce merged commit db22f6e into main Apr 17, 2021
@mark-dce mark-dce deleted the only_superusers_update_embargos branch April 17, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-dce mark-dce mark-dce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxkadel @coveralls @mark-dce @fnibbit