-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix energy_bias_resolution_from_energy_dispersion #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 95.35% 95.36% +0.01%
==========================================
Files 60 60
Lines 3097 3109 +12
==========================================
+ Hits 2953 2965 +12
Misses 144 144
☔ View full report in Codecov by Sentry. |
maxnoe
force-pushed
the
fix_bias_resolution_from_edisp
branch
from
October 19, 2023 09:44
ee4e8ea
to
d72925a
Compare
This function still assumed the wrong normalization of the energy dispersion fixed in pyirf 0.10.
maxnoe
force-pushed
the
fix_bias_resolution_from_edisp
branch
from
October 19, 2023 09:44
d72925a
to
29bd509
Compare
Tobychev
previously approved these changes
Oct 19, 2023
In case there is nothing in an energy bin |
Tobychev
previously approved these changes
Oct 27, 2023
Tobychev
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function still assumed the wrong normalization of the energy dispersion fixed in pyirf 0.10.