You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When calling energy_dispersion_to_migration on a normalized energy dispersion histogram (right) I get a different
result than building the migration matrix directly from the data (center)
the right plot is a crosscheck with gammapy to_edisp_kernel, but in that case, one needs to choose a FoV offset angle (in this case I put 0 deg), but the first 2 plots have all offsets.
One culprit seems to be at least the fact that this function was not updated after #268
I suggest also improving the current units test to compare the 2 histograms.
The text was updated successfully, but these errors were encountered:
When calling
energy_dispersion_to_migration
on a normalized energy dispersion histogram (right) I get a differentresult than building the migration matrix directly from the data (center)
the right plot is a crosscheck with gammapy to_edisp_kernel, but in that case, one needs to choose a FoV offset angle (in this case I put 0 deg), but the first 2 plots have all offsets.
One culprit seems to be at least the fact that this function was not updated after #268
I suggest also improving the current units test to compare the 2 histograms.
The text was updated successfully, but these errors were encountered: