-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize edisp to integral of 1, not sum of 1 #250
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 94.73% 94.78% +0.05%
==========================================
Files 60 60
Lines 2981 3050 +69
==========================================
+ Hits 2824 2891 +67
- Misses 157 159 +2
☔ View full report in Codecov by Sentry. |
Yes, it does. At the moment Edit: There are probably more things that need to be changed. E.g. adding some factors to I'm however not sure how this effects the performance of the algorithms. All EDisps I've used so far for testing summed to one as they were computed with pyirf. |
…lue != 0 in moment morphing
Start working on fixing interpolation for fixed edisp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides some minor docstring updates and a missing test I did not find any major things here. (And ofc we need a changelog entry here, but I guess this one is obvious)
@RuneDominik done |
@RuneDominik does this have also implications on the interpolation code?