TUS upload support through datagateway #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 24, 2020
labkode
approved these changes
Jun 25, 2020
|
@kulmann how was this tested? please list scenarios (ex phoenix, cli, etc) |
Together with this PR in ocis-reva which changes default configs to run uploads through the proxy and PR in ocis-proxy which shows the required
|
butonic
reviewed
Jun 25, 2020
| @@ -238,3 +248,69 @@ func (s *svc) doPut(w http.ResponseWriter, r *http.Request) { | |||
| log.Err(err).Msg("error writing body after header were set") | |||
| } | |||
| } | |||
|
|
|||
| // TODO: put and post code is pretty much the same. Should be solved in a nicer way in the long run. | |||
butonic
approved these changes
Jun 25, 2020
|
Ok, I've tested TUS upload with Phoenix and it worked fine 👍 |
butonic
requested changes
Jun 25, 2020
No-go to have a config variable and then render it useless by hardcoding it to true.
Since TUS clients don't understand the reva transfer token, we need to make sure that the upload endpoint comes out as a URL that encodes the full endpoint path, not only the data gateway path.
kulmann
force-pushed
the
allow-transfer-token-in-url
branch
from
33775ca to
8d0105c
Compare
|
rebasing fixed config issues. good to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In oCIS we want to be able to upload data through one single entrypoint and let the datagateway take care of dispatching the request to the respective
storagedata server. Reva already supports this by encoding the upload endpoint in anX-Reva-Transfertoken.This PR is about four things:
storagesdata servers are not exposed (i.e. as soon as a transfer token exists). Of course we want reva to still continue to work with the token. To achieve this, the datagateway now checks if a transfer token is present in the token verification step. If it's not present, we use the last segment of the request path as the transfer token.put.go.ExposeDataServer = true.Also one small change: I've changed the datagateway to expose the
X-Reva-Transferconstant and used it in all places where the string was hardcoded before. Makes it easier to find code fragments where the transfer token is used.Happy to hear feedback on this.