Integrate TUS endpoint with ocis-proxy

[exalate-issue-sync]

owncloud/ocis-proxy#44

possible solution owncloud/ocis-proxy#44 (comment)

Tasks

• Add a mapping for /data to the datagateway (REVA_FRONTEND) in the proxy
• Adjust the default configuration
• Encode REVA transport token in the upload endpoint (ocdav), because TUS doesn't understand the transport token in the header. TUS just needs an endpoint.
• Teach datagateway to extract the token from the full url and convert it back into a REVA transport token
• Teach datagateway to make a PATCH
• Fix upload initiation bug in ocis-web - looks like this is only some caching bug in Chrome on my machine ( @kulmann ). Private Chrome session + Firefox work like expected.

Estimation

Complexity: S
Effort: S

Related to Tracing https://github.com/owncloud/ocis/issues/277

[exalate-issue-sync]

Remote key is https://jira.owncloud.com/browse/OCIS-79

[exalate-issue-sync]

Remote key is https://jira.owncloud.com/browse/OCIS-79

[butonic]

[kulmann]

PR is here cs3org/reva#878 @butonic @PVince81

Also needed:
owncloud/ocis-reva#261 and owncloud/ocis-proxy#45

[kulmann]

^ successful upload through proxy, with reva transfer token in the URL and reva routing through the datagateway.

[PVince81]

I checked out the three PRs and tested it in Phoenix (the Phoenix version in ocis, not master)

The URL is replaced correctly in the returned "Location" header of the initial POST.
However the PATCH request fails with a 404.

Is there any additional non-default configuration to set ?

[kulmann]

I checked out the three PRs and tested it in Phoenix (the Phoenix version in ocis, not master)

The URL is replaced correctly in the returned "Location" header of the initial POST.
However the PATCH request fails with a 404.

Is there any additional non-default configuration to set ?

Did you start oCIS with proxy config file? /data endpoint is not included in the builtin routes. I added the /data endpoint to the builtin default routes.

[PVince81]

Works now, I pulled your latest ocis-proxy changes

[kulmann]

Oh by the way, I tested with phoenix in current master and with ocis-phoenix in ocis single binary. Behaviour was the same in both versions (was expected, but still good to know).

[PVince81]

next steps:

• fix TUS upload support through datagateway cs3org/reva#878 to not break public uploads, @jfd was fixed by rebase
• set expose to false in public storage provider there as well and test, @kulmann fixed by https://github.com/owncloud/ocis-reva/pull/261/files
• wait for reva PR merge: TUS upload support through datagateway cs3org/reva#878
• update ocis-reva to get the latest reva with the changes, then merge it if all green, @jfd updating the config
• rebase then merge Point frontend to proxy ocis-reva#261
• merge Point /data to reva frontend ocis-proxy#45

[PVince81]

it appears that merging cs3org/reva#878 would break public link upload, so we cannot merge it without solving the issue: cs3org/reva#878 (review)

if you need to touch it anyway then let's rebase on top of latest reva. I'll adjust the checkbox list

[kulmann]

Closed with owncloud/ocis-reva#261 and owncloud/ocis-proxy#45