Move oidc auth into a token manager #382
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hurts ... but the oidc auth manager does not make sense. I used to store the claims in the context, but with the gateway this was removed. Now, the oidc user manager has no way of resolving the claims, other than trying to do a userinfo lookup ... which the auth manager already did. Furthermore, oidc already uses a token. We should treat it as such.
This PR
This makes a lot more sense and reduces the number of requests significantly if the token is a jwt.
We may want to replace the oidc token with a custom jwt token to convert opaque access tokens to jwt ones. We also need to reflect this in the documentation. In a subsequest PR or commit ....