Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
born out of cs3org/reva#382 and the previous discussion in cs3org/reva#239 (comment)
The userid is not good enough:
Even the basic auth provider can return a username and a userid.
The job of the auth provider is to establish the identity of the user and return a stable identifier. But he should be allowed to provide more 'claims'.
I also cleaned up the user type to get rid of the direct
subject
andissuer
members, which are part of the id. And I added themail_verified
member ....TBH I would just add all oidc standard claims ... in a subsequent PR. For now, this would be awesome!