Render additional share with info in ocs sharing api #1451
Conversation
| ShareWith: u.Username, | ||
| // api compatability with oc10: always use the username | ||
| ShareWith: u.Username, | ||
| ShareWithAdditionalInfo: u.Mail, |
There was a problem hiding this comment.
oc10 lets the admin decide if the additional info should be Mail or UserID. For full compatibility you could make the attribute configurable here as well 🤷
There was a problem hiding this comment.
Maybe later. For now, I just want to be able to distinguish the users. And email is what users know from their email client. Furthermore, for guests the username equals the email. Since we want to unify sharing with people I prefer the mail.
When searching recipients, the username is available as the shareWith, anyway. The Displayname is in the Label ... which only leaves email 🤷♂️
There was a problem hiding this comment.
But with this PR we'll lose the option to hide it. Because ownCloud Web renders the ShareWithAdditionalInfo as soon as it exists. Unnecessary info for small instances... 👀
There was a problem hiding this comment.
I don't think it is unnecessary. I think we should align on emails because they allow using the federated discovery mechanism described by openid connect. phoenix could actually do that instead of using the ocs api ... or ... well ... in addition ...
but that is a product management decision.
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
additional-share-with
branch
from
4d8ac54 to
7799cdb
Compare
butonic
changed the title
butonic
changed the title
| gatewayAddr string | ||
| publicURL string | ||
| sharePrefix string | ||
| userIdentifierCache *ttlmap.TTLMap |
There was a problem hiding this comment.
We can use github.com/ReneKroon/ttlcache which I used for the etag cache.
Recipients can now be distinguished by their email, which is rendered as additional info in the ocs api for share and file owners as well as share recipients.
Fixes owncloud/ocis#1190