add userid to username mapping to public shares #1376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
previously approved these changes
Dec 16, 2020
butonic
previously approved these changes
Dec 16, 2020
C0rby
force-pushed
the
map-userid-username-public-share
branch
from
44f0e75 to
a00412f
Compare
refs
previously approved these changes
Dec 17, 2020
|
Perhaps this needs to be rebased with |
|
Hmm, well let's try. 🧐 |
C0rby
force-pushed
the
map-userid-username-public-share
branch
from
a00412f to
5b3aad9
Compare
|
Seems like we have random etag test failures again... 🎉 |
refs
previously approved these changes
Dec 17, 2020
kulmann
previously approved these changes
Dec 17, 2020
|
@C0rby can you rebase? |
C0rby
force-pushed
the
map-userid-username-public-share
branch
from
5b3aad9 to
be34067
Compare
|
I'm closing this PR because this change was also implemented by #1451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed some spots for public shares