Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Set#to_a(&) #14519

Merged
merged 5 commits into from
May 13, 2024
Merged

Fix Set#to_a(&) #14519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5fc7fc6
Fix to_a method
meatball133 Apr 21, 2024
da4e437
Add test case to test for giving a block
meatball133 Apr 21, 2024
f304d6e
Update Formating of spec file
meatball133 Apr 21, 2024
a9d879c
Add missing do
meatball133 Apr 22, 2024
5caa18d
Update spec/std/set_spec.cr
meatball133 Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions spec/std/set_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,10 @@ describe "Set" do
Set{1, 2, 3}.to_a.should eq([1, 2, 3])
end

it "does support giving a block to to_a" do
Set{1, 2, 3}.to_a { |x| x + 1 }.should eq([2, 3, 4])
end

it "does to_s" do
Set{1, 2, 3}.to_s.should eq("Set{1, 2, 3}")
Set{"foo"}.to_s.should eq(%(Set{"foo"}))
Expand Down
4 changes: 2 additions & 2 deletions src/set.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,12 +385,12 @@ struct Set(T)
# Returns an `Array` with the results of running *block* against each element of the collection.
#
# ```
# Set{1, 2, 3, 4, 5}.to_a { |i| i // 2 } # => [0, 1, 2]
# Set{1, 2, 3, 4, 5}.to_a { |i| i // 2 } # => [0, 1, 1, 2, 2]
# ```
def to_a(& : T -> U) : Array(U) forall U
array = Array(U).new(size)
@hash.each_key do |key|
array << key
array << yield key
end
array
end
Expand Down
Loading