Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Set#to_a(&) #14519

Merged
merged 5 commits into from
May 13, 2024
Merged

Fix Set#to_a(&) #14519

merged 5 commits into from
May 13, 2024

Conversation

meatball133
Copy link
Contributor

⚠️ This pr includes breaking changes ⚠️

resolves #14518

@Blacksmoke16 Blacksmoke16 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. breaking-change topic:stdlib:collection labels Apr 21, 2024
devnote-dev
devnote-dev reviewed Apr 21, 2024
View reviewed changes
spec/std/set_spec.cr Outdated Show resolved Hide resolved
@meatball133 @devnote-dev
Update Formating of spec file
f304d6e 
Co-authored-by: Devonte W <devnote.dev75@gmail.com>
Sija
Sija reviewed Apr 22, 2024
View reviewed changes
spec/std/set_spec.cr Outdated Show resolved Hide resolved
@straight-shoota straight-shoota changed the title Fix Set#to_a& Fix Set#to_a(&) Apr 22, 2024
@HertzDevil
Copy link
Contributor

I don't think this counts as a breaking change?

@straight-shoota
Copy link
Member

Technically it's breaking the current behaviour of this method. Of course it was bullocks, so the fix is necessary.
We don't categorize it as a breaking change but a bug fix. Still it'll be highlighted in the changelog due to the potential for breaking something.

@meatball133 @Sija
Update spec/std/set_spec.cr
5caa18d 
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
beta-ziliani
beta-ziliani approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @meatball133 !

@beta-ziliani beta-ziliani added this to the 1.13.0 milestone May 10, 2024
@straight-shoota straight-shoota merged commit 8b2bd98 into crystal-lang:master May 13, 2024
60 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jul 10, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

@devnote-dev devnote-dev devnote-dev approved these changes

@beta-ziliani beta-ziliani beta-ziliani approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
breaking-change kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:collection
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Set#to_a& works the same as to_a
7 participants
@meatball133 @HertzDevil @straight-shoota @Sija @beta-ziliani @devnote-dev @Blacksmoke16