Fix Range#== to ignore generic type arguments #10309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:bug
asterite
approved these changes
Jan 27, 2021
Sija
reviewed
Jan 27, 2021
bcardiff
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1..1) == (1.0..1.0)currently returnsfalse. The equality operatorStruct#==includes a type restriction toselfbut the types are different because of generic type arguments:Range(Int32, Int32)andRange(Float64, Float64).The same problem appears with nilable generic type arguments like comparing
Range(Int32?, Int32?)withRange(Int32, Int32)always fails, even if both have identical begin and end values.This patch overrides the equality operator as
Range#==(other : Range)which defines quality based on actual values, ignoring generic type arguments.A more comprehensive fix would be to change the type restriction in
Struct#==fromselfto the generic class type. I'll look into that, too. But this is a minimal fix for now and IMO worth merging as is.