Fix Range#== to ignore generic type arguments (#10309)

crystal-lang · Feb 12, 2021 · 6310431 · 6310431
1 parent 45a5703
commit 6310431
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/spec/std/range_spec.cr b/spec/std/range_spec.cr
@@ -60,6 +60,19 @@ describe "Range" do
     r.excludes_end?.should be_true
   end
 
+  it "#==" do
+    ((1..1) == (1..1)).should be_true
+    ((1...1) == (1..1)).should be_false
+    ((1...1) == (1...1)).should be_true
+    ((1..1) == (1...1)).should be_false
+
+    ((1..nil) == (1..nil)).should be_true
+
+    (1..1).should eq Range(Int32?, Int32?).new(1, 1)
+    ((1..1) == Range(Int32?, Int32?).new(1, 1)).should be_true
+    ((1.0..1.0) == (1..1)).should be_true
+  end
+
   it "includes?" do
     (1..5).includes?(1).should be_true
     (1..5).includes?(5).should be_true

diff --git a/src/range.cr b/src/range.cr
@@ -87,6 +87,10 @@ struct Range(B, E)
   def initialize(@begin : B, @end : E, @exclusive : Bool = false)
   end
 
+  def ==(other : Range)
+    @begin == other.@begin && @end == other.@end && @exclusive == other.@exclusive
+  end
+
   # Returns an `Iterator` that cycles over the values of this range.
   #
   # ```