Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: can't support prevrando opcode (backport #443) #444

Merged

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Mar 29, 2024

  • Problem: no proper error msg for unsupported opcode

  • panic specific

  • fix test

  • update deps

  • Apply suggestions from code review

  • Apply suggestions from code review

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

* Problem: no proper error msg for unsupported opcode

* panic specific

* fix test

* update deps

* Apply suggestions from code review

* Apply suggestions from code review
@mmsqe mmsqe requested a review from yihuang March 29, 2024 08:29
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 63.39%. Comparing base (0cbadd0) to head (97624df).

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           release/v0.21.x-cronos     #444   +/-   ##
=======================================================
  Coverage                   63.39%   63.39%           
=======================================================
  Files                         129      129           
  Lines                       12269    12280   +11     
=======================================================
+ Hits                         7778     7785    +7     
- Misses                       3988     3991    +3     
- Partials                      503      504    +1     
Files Coverage Δ
app/app.go 84.15% <100.00%> (+0.02%) ⬆️
x/evm/keeper/keeper.go 87.77% <100.00%> (+0.34%) ⬆️
x/evm/keeper/state_transition.go 73.46% <42.85%> (-0.93%) ⬇️

@mmsqe mmsqe enabled auto-merge (squash) April 2, 2024 03:11
@mmsqe mmsqe disabled auto-merge April 2, 2024 03:35
@mmsqe mmsqe merged commit 2740d1f into crypto-org-chain:release/v0.21.x-cronos Apr 2, 2024
28 of 31 checks passed
@yihuang yihuang deleted the prevrandao_backport branch April 2, 2024 03:36
mmsqe added a commit that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants