Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: can't support prevrando opcode #443

Merged
merged 6 commits into from
Mar 29, 2024
Merged

Problem: can't support prevrando opcode #443

merged 6 commits into from
Mar 29, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Mar 28, 2024 •
edited
Loading

0x44 rename from DIFFICULTY to PREVRANDAO

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe requested a review from yihuang March 28, 2024 12:20
@mmsqe mmsqe force-pushed the prevrandao branch 3 times, most recently from 432a36b to e2c076a Compare March 29, 2024 00:52
@mmsqe mmsqe changed the title Problem: no proper err msg for unsupported opcode Problem: behavior of prevrandao differs from difficulty opcode Mar 29, 2024
yihuang
yihuang reviewed Mar 29, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@yihuang yihuang changed the title Problem: behavior of prevrandao differs from difficulty opcode Problem: can't support prevrando opcode Mar 29, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.56%. Comparing base (213ddbc) to head (6a0cf8c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #443   +/-   ##
========================================
  Coverage    62.56%   62.56%           
========================================
  Files          130      130           
  Lines        12512    12513    +1     
========================================
+ Hits          7828     7829    +1     
  Misses        4138     4138           
  Partials       546      546
Files Coverage Δ
x/evm/keeper/state_transition.go 72.10% <100.00%> (+0.09%) ⬆️

@yihuang yihuang enabled auto-merge (squash) March 29, 2024 06:50
@yihuang yihuang merged commit e3e4649 into crypto-org-chain:develop Mar 29, 2024
36 of 39 checks passed
mmsqe added a commit that referenced this pull request Apr 2, 2024
@mmsqe
Problem: can't support prevrando opcode (backport #443) (#444)
2740d1f 
* Problem: can't support prevrando opcode (#443)

* Problem: no proper error msg for unsupported opcode

* panic specific

* fix test

* update deps

* Apply suggestions from code review

* Apply suggestions from code review

* keep default nil

* clean doc
mmsqe added a commit that referenced this pull request Apr 15, 2024
@mmsqe
Revert "Problem: can't support prevrando opcode (backport #443) (#444)…
38f7e5d 
…" (#468)

This reverts commit 2740d1f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihuang yihuang yihuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmsqe @yihuang