Skip to content

Apply suggestions from code review

GitHub Advanced Security / gosec failed Nov 29, 2023 in 4s

3 new alerts including 2 errors

New alerts in code changed by this pull request

  • 2 errors
  • 1 warning

See annotations below for details.

View all branch alerts.

Annotations

Check failure on line 128 in x/cronos/keeper/precompiles/relayer.go

See this annotation in the file changed.

Code scanning / gosec

the value in the range statement should be _ unless copying a map: want: for key := range m Error

expected exactly 1 statement (either append, delete, or copying to another map) in a range with a map, got 4

Check failure on line 157 in x/cronos/keeper/precompiles/relayer.go

See this annotation in the file changed.

Code scanning / gosec

Potential integer overflow by integer type conversion Error

Potential integer overflow by integer type conversion

Check warning on line 161 in x/cronos/keeper/precompiles/relayer.go

See this annotation in the file changed.

Code scanning / gosec

Returned error is not propagated up the stack. Warning

Returned error is not propagated up the stack.