Apply suggestions from code review

integration_tests/test_ibc_rly_gas.py

@@ -27,5 +27,5 @@ def test_ibc(ibc):
         records.append(record)
     if len(records) == 2:
         for e1, e2 in zip(*records):
-            res = int(e2) / int(e1)
+            res = float(e2) / float(e1)
             assert 1 - diff <= res <= 1 + diff, res

x/cronos/keeper/precompiles/relayer.go

@@ -2,6 +2,7 @@ package precompiles
 
 import (
 	"errors"
+	"fmt"
 
 	"github.com/cometbft/cometbft/libs/log"
 	"github.com/cosmos/cosmos-sdk/codec"
@@ -180,6 +181,9 @@ func (bc *RelayerContract) Run(evm *vm.EVM, contract *vm.Contract, readonly bool
 	if readonly {
 		return nil, errors.New("the method is not readonly")
 	}
+	if len(contract.Input) < 4 {
+		return nil, errors.New("input too short")
+	}
 	// parse input
 	methodID := contract.Input[:4]
 	method, err := irelayerABI.MethodById(methodID)
@@ -273,7 +277,7 @@ func (bc *RelayerContract) Run(evm *vm.EVM, contract *vm.Contract, readonly bool
 	case UpdateClientAndTimeoutOnClose:
 		res, err = execMultiple(e, bc.ibcKeeper.UpdateClient, bc.ibcKeeper.TimeoutOnClose)
 	default:
-		return nil, errors.New("unknown method")
+		return nil, fmt.Errorf("unknown method: %s", method.Name)
 	}
 	return res, err
 }

x/cronos/keeper/precompiles/utils.go

@@ -43,8 +43,9 @@ func exec[Req any, PReq interface {
 	if len(signers) != 1 {
 		return nil, errors.New("don't support multi-signers message")
 	}
-	if common.BytesToAddress(signers[0].Bytes()) != e.caller {
-		return nil, errors.New("caller is not authenticated")
+	caller := common.BytesToAddress(signers[0].Bytes())
+	if caller != e.caller {
+		return nil, fmt.Errorf("caller is not authenticated: expected %s, got %s", e.caller.Hex(), caller.Hex())
 	}
 
 	var res Resp
@@ -56,7 +57,11 @@ func exec[Req any, PReq interface {
 		return nil, err
 	}
 
-	return e.cdc.Marshal(res)
+	output, err := e.cdc.Marshal(res)
+	if err != nil {
+		return nil, fmt.Errorf("fail to Marshal %T %w", res, err)
+	}
+	return output, nil
 }
 
 func execMultipleWithHooks[Req any,
@@ -89,7 +94,7 @@ func execMultipleWithHooks[Req any,
 
 	signers := msg.GetSigners()
 	if len(signers) != 1 {
-		return nil, errors.New("don't support multi-signers message")
+		return nil, fmt.Errorf("expected 1 signer, got %d", len(signers))
 	}
 	if common.BytesToAddress(signers[0].Bytes()) != e.caller {
 		return nil, errors.New("caller is not authenticated")