Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: failed tx are ignored in json-rpc apis #502

Merged
merged 4 commits into from
Jun 6, 2022
Merged

Problem: failed tx are ignored in json-rpc apis #502

merged 4 commits into from
Jun 6, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented May 24, 2022

Solution:

  • fix the issue in ethermint by emitting extra events in ante handler.
  • add integration test to test it.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

yihuang
yihuang commented May 24, 2022
View reviewed changes
go.mod Outdated
@@ -163,5 +163,7 @@ replace (
// TODO: remove when gravity update dependencies
github.com/peggyjv/gravity-bridge/module/v2 => github.com/crypto-org-chain/gravity-bridge/module/v2 v2.0.0-20220509015341-a016e2b04866

github.com/tharsis/ethermint => github.com/yihuang/ethermint v0.6.1-0.20220524072845-48dfc975f7ba
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evmos/ethermint#1062

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same question in #504
Why the main branch is still using ethermint v0.6.1?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s not, what matters is the commit hash, the tag name is inferred by golang compiler from the forked repo

yihuang added a commit to yihuang/cronos that referenced this pull request May 24, 2022
@yihuang
Problem: failed tx are ignored in json-rpc apis (backport crypto-org-…
7a3a66a 
…chain#502)

Solution:
- fix the issue in ethermint by emitting extra events in ante handler.
- add integration test to test it.
- update cosmos-sdk dependency
@yihuang yihuang force-pushed the debug-emit-tx-hash branch 2 times, most recently from 9b7e4f6 to 87b6c58 Compare May 31, 2022 06:27
@yihuang
Problem: failed tx are ignored in json-rpc apis
24ec0f3 
Solution:
- fix the issue in ethermint by emitting extra events in ante handler.
- add integration test to test it.

update cosmos-sdk dependency

changelog and fix test

gomod2nix

fix get tx by index

fix getTransactionReceiptsByBlock

update gomod2nix.toml
@yihuang
change integration test to reveal a bug
2f19dc8
@yihuang
use ethermint upstream main
9dc77f4
@yihuang yihuang marked this pull request as ready for review May 31, 2022 11:34
@yihuang yihuang requested a review from a team as a code owner May 31, 2022 11:34
@yihuang yihuang requested review from JayT106 and leejw51crypto and removed request for a team May 31, 2022 11:34
JayT106
JayT106 reviewed May 31, 2022
View reviewed changes
integration_tests/test_replay_block.py
@@ -26,19 +26,23 @@ def test_replay_block(custom_cronos):
)
iterations = 400
gas_limit = 800000
gas_price = 100000000000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use 10**11 for readability?

@JayT106
Copy link
Collaborator

JayT106 commented May 31, 2022

LGTM

yihuang added a commit to yihuang/cronos that referenced this pull request Jun 6, 2022
@yihuang
Problem: failed tx are ignored in json-rpc apis (backport crypto-org-…
4cb4833 
…chain#502)

Solution:
- fix the issue in ethermint by emitting extra events in ante handler.
- add integration test to test it.
- update cosmos-sdk dependency
- fix getTransactionReceiptsByBlock
@yihuang yihuang merged commit 46cf38f into crypto-org-chain:main Jun 6, 2022
@yihuang yihuang deleted the debug-emit-tx-hash branch June 6, 2022 02:07
yihuang added a commit to yihuang/cronos that referenced this pull request Jun 6, 2022
@yihuang
Problem: failed tx are ignored in json-rpc apis (backport crypto-org-…
a44ec25 
…chain#502)

Solution:
- fix the issue in ethermint by emitting extra events in ante handler.
- add integration test to test it.
- update cosmos-sdk dependency
- fix getTransactionReceiptsByBlock
yihuang added a commit to yihuang/cronos that referenced this pull request Jun 13, 2022
@yihuang
Problem: failed tx are ignored in json-rpc apis (backport crypto-org-…
b90b527 
…chain#502)

Solution:
- fix the issue in ethermint by emitting extra events in ante handler.
- add integration test to test it.
- update cosmos-sdk dependency
- fix getTransactionReceiptsByBlock

fix integration test

move to crypto-org-chain repo

Update CHANGELOG.md

update cosmos-sdk to most recent

cosmos-sdk v0.45.5

Problem: gravity bridge integration test fails occasionally (crypto-org-chain#538)

* Problem: gravity bridge integration test fails occasionally

WIP: crypto-org-chain#48

- Add traceback env var to debug

* run ibc test together

* avoid port conflict

* Update scripts/run-integration-tests
yihuang added a commit that referenced this pull request Jun 14, 2022
@yihuang
Problem: failed tx are ignored in json-rpc apis (backport #502) (#503)
75c2672 
* Problem: failed tx are ignored in json-rpc apis (backport #502)

Solution:
- fix the issue in ethermint by emitting extra events in ante handler.
- add integration test to test it.
- update cosmos-sdk dependency
- fix getTransactionReceiptsByBlock

fix integration test

move to crypto-org-chain repo

Update CHANGELOG.md

update cosmos-sdk to most recent

cosmos-sdk v0.45.5

Problem: gravity bridge integration test fails occasionally (#538)

* Problem: gravity bridge integration test fails occasionally

WIP: #48

- Add traceback env var to debug

* run ibc test together

* avoid port conflict

* Update scripts/run-integration-tests

* delay start of gorc
@coderabbitai coderabbitai bot mentioned this pull request Apr 19, 2024
Merged
13 tasks
This was referenced Apr 26, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request May 3, 2024
Merged
13 tasks
This was referenced May 21, 2024
Merged
Merged
This was referenced May 30, 2024
Merged
Merged
Open
Merged
This was referenced Jun 6, 2024
Merged
Merged
This was referenced Jun 26, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayT106 JayT106 JayT106 approved these changes

@leejw51crypto leejw51crypto Awaiting requested review from leejw51crypto leejw51crypto is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihuang @JayT106