Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: pending tx comes after get mined #1466

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Problem: pending tx comes after get mined #1466

merged 1 commit into from
Jun 7, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jun 6, 2024 •
edited by coderabbitai bot
Loading

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • New Features

    • Added functionality to register listeners for pending transactions, enhancing transaction monitoring.

  • Bug Fixes

    • Fixed an issue in the API's handling of pending transactions to prevent invalid elasticity_multiplier errors.

  • Tests

    • Updated integration tests to ensure accurate assertion checks for pending transactions in the mempool.

@mmsqe mmsqe requested a review from a team as a code owner June 6, 2024 13:11
@mmsqe mmsqe requested review from JayT106 and thomas-nguy and removed request for a team June 6, 2024 13:11
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 6, 2024 •
edited
Loading

Walkthrough

This update introduces enhancements to the transaction handling mechanism within the app, including the addition of a pendingTxListeners slice and a method to register listeners for pending transactions. It also updates the version and hash of the ethermint module and adjusts integration tests to align with the new transaction handling logic.

Changes

File Change Summary
CHANGELOG.md Documented the bug fix in the rpc module for handling pending transactions and elasticity_multiplier.
app/app.go Added pendingTxListeners slice and RegisterPendingTxListener method to manage pending transactions.
gomod2nix.toml Updated ethermint module version and hash.
integration_tests/test_mempool.py Adjusted assertion checks for pending transactions to match expected counts.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant App
    participant TxListener

    User->>App: Submit Transaction
    App->>App: CheckTx Method
    App->>TxListener: Notify PendingTxListeners
    TxListener->>App: Acknowledge Pending Transaction
    App->>User: Transaction Processed
Loading

Poem

In the code where transactions flow,
New listeners now in tow,
Pending checks, no more woe,
With updates swift, we grow.
Bugs fixed, tests align,
Our app now runs just fine. 🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d41d670 and 0955f82.

Files ignored due to path filters (2)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum
Files selected for processing (4)
  • CHANGELOG.md (1 hunks)
  • app/app.go (2 hunks)
  • gomod2nix.toml (1 hunks)
  • integration_tests/test_mempool.py (1 hunks)
Files not reviewed due to errors (1)
  • integration_tests/test_mempool.py (no review received)
Additional context used
LanguageTool
CHANGELOG.md

[grammar] ~21-~21: The conjunction “when” requires the past participle “registered”. Or did you mean “you register”? (IF_VB_PCT)
Context: ...ronos/pull/1421) Validate e2ee key when register. * (store) [#1448](https://github.com/c...

[misspelling] ~125-~125: Did you mean “or”? ‘Of’ refers to parts of a whole, while ‘or’ refers to alternatives. (CONFUSION_OF_OR)
Context: ...onos/pull/1216) Update ethermint to fix of avoid redundant parse chainID from gens...

[style] ~166-~166: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...n processing and double spend check. - [cronos#742](https://github.com/crypto-org-chai...

[style] ~167-~167: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...e handler for v0.8.0-gravity-alpha2. - [cronos#750](https://github.com/crypto-org-chai...

[style] ~168-~168: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...e handler for v0.8.0-gravity-alpha3. - [cronos#769](https://github.com/crypto-org-chai...

[style] ~169-~169: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...cope of the contract that manage it. - [cronos#775](https://github.com/crypto-org-chai...

[style] ~170-~170: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...775) Support turnbridge transaction. - [cronos#781](https://github.com/crypto-org-chai...

[style] ~171-~171: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: .../cronos/pull/781) Add prune command. - [cronos#830](https://github.com/crypto-org-chai...

[style] ~174-~174: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...upgrade handler for v2.0.0-testnet3. - [cronos#795](https://github.com/crypto-org-chai...

[style] ~175-~175: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: .../795) Support permissions in cronos. - [cronos#997](https://github.com/crypto-org-chai...

[style] ~176-~176: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ontract for cronos originated crc20. - [cronos#1005](https://github.com/crypto-org-cha...

[style] ~177-~177: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...o-ibc event in case of source token. - [cronos#1069](https://github.com/crypto-org-cha...

[style] ~178-~178: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...o v1.10.26 and ibc-go to v6.2.0. - [cronos#1147](https://github.com/crypto-org-cha...

[style] ~182-~182: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...adjusted correctly in ibc-go v7.2.0. - [cronos#1163](https://github.com/crypto-org-cha...

[style] ~183-~183: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ateful precompiled contract for ica. - [cronos#837](https://github.com/crypto-org-chai...

[style] ~184-~184: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...teful precompiled contract for bank. - [cronos#1184](https://github.com/crypto-org-cha...

[style] ~185-~185: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ull/1184) Update ibc-go to v7.3.1. - [cronos#1186](https://github.com/crypto-org-cha...

[style] ~186-~186: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... max block gas limit in new version. - [cronos#1187](https://github.com/crypto-org-cha...

[style] ~187-~187: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...1187) Disable gravity module in app. - [cronos#1185](https://github.com/crypto-org-cha...

[style] ~188-~188: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...nos/pull/1185) Support ibc callback. - [cronos#1196](https://github.com/crypto-org-cha...

[grammar] ~207-~207: It seems that “to” is missing before the verb. (MISSING_TO_BETWEEN_BE_AND_VB)
Context: .../cronos/pull/1150) Fix memiavl's unsafe retain of the root hashes. ### Features - [#...

[misspelling] ~211-~211: Did you mean the phrasal verb “clean up” instead of the noun ‘cleanup’? (CLEAN_UP)
Context: .../pull/1042) call Close method on app to cleanup resource on graceful shutdown ([ethermi...

[grammar] ~327-~327: After ‘it’, use the third-person verb form “fixes”. (IT_VBZ)
Context: ...790) Update cosmos-sdk to v0.46.7, it fix a migration issue which affects pending...

[style] ~394-~394: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...file state streamer (backport #702). - [cronos#730](https://github.com/crypto-org-chai...

[style] ~416-~416: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...elSendToChain support from evm call. - [cronos#600](https://github.com/crypto-org-chai...

[style] ~417-~417: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...plement bidirectional token mapping. - [cronos#611](https://github.com/crypto-org-chai...

[style] ~418-~418: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...owledgement error in ibc middleware. - [cronos#627](https://github.com/crypto-org-chai...

[style] ~433-~433: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...leware, use ibc-go upstream version. - [cronos#550](https://github.com/crypto-org-chai...

[style] ~434-~434: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...basic json-rpc apis on pruned nodes. - [cronos#549](https://github.com/crypto-org-chai...

[style] ~435-~435: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...tom tx indexer feature of ethermint. - [cronos#673](https://github.com/crypto-org-chai...

[style] ~453-~453: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ed in json-rpc apis (backport #502). - [cronos#526](https://github.com/crypto-org-chai...

[style] ~454-~454: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... Fix tendermint duplicated tx issue. - [cronos#584](https://github.com/crypto-org-chai...

[style] ~455-~455: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...shes returned in some JSON-RPC apis. - [cronos#587](https://github.com/crypto-org-chai...

[style] ~456-~456: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... tx patch cmd recompute eth tx hash. - [cronos#595](https://github.com/crypto-org-chai...

[style] ~462-~462: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...nd to patch txs post v0.7.0 upgrade. - [cronos#522](https://github.com/crypto-org-chai...

[style] ~463-~463: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... the tendermint tx duplicated issue. - [cronos#585](https://github.com/crypto-org-chai...

[style] ~477-~477: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ase fee related logic in the code. - [ethermint#817](https://github.com/tharsis/ethermi...

[style] ~478-~478: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ogic related to effectiveGasPrice. - [ethermint#822](https://github.com/tharsis/ethermi...

[style] ~481-~481: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... tx when block gas limit exceeded. - [cosmos-sdk#10725](https://github.com/cosmos/cosmos...

[style] ~489-~489: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...e url query parameter in swagger-ui. - [cronos#328](https://github.com/crypto-org-chai...

[style] ~490-~490: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...query result when --trace enabled. - [cronos#441](https://github.com/crypto-org-chai...

[style] ~497-~497: ‘prior to’ might be wordy. Consider a shorter alternative. (EN_WORDINESS_PREMIUM_PRIOR_TO)
Context: ...ll/329) Fix panic of eth_call on blocks prior to upgrade. - [cronos#340](https://github....

[style] ~498-~498: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...eth_call on blocks prior to upgrade. - [cronos#340](https://github.com/crypto-org-chai...

[style] ~499-~499: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...t, b) fix data races traceContext. - [cronos#370](https://github.com/crypto-org-chai...

[style] ~500-~500: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...g, add websockets integration tests. - [cronos#378](https://github.com/crypto-org-chai...

[style] ~501-~501: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... add returnValue message on tracing. - [cronos#446](https://github.com/crypto-org-chai...

[grammar] ~621-~621: After ‘it’, use the third-person verb form “upgrades”. (IT_VBZ)
Context: ...org Chain. In addition to that, it also upgrade ethermint to its latest version (v0.5.0...

[uncategorized] ~659-~659: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ... version is a new scaffolding of cronos project where ethermint is included as a librar...

Markdownlint
CHANGELOG.md

49-49: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

61-61: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

69-69: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

77-77: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

85-85: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

86-86: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

87-87: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

91-91: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

99-99: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

100-100: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

101-101: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

102-102: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

103-103: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

104-104: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

108-108: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

109-109: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

115-115: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

116-116: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

117-117: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

118-118: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

119-119: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

123-123: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

124-124: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

125-125: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

126-126: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

127-127: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

128-128: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

132-132: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

133-133: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

134-134: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

135-135: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

136-136: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

137-137: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

141-141: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

142-142: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

143-143: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

151-151: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

152-152: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

156-156: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

164-164: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

165-165: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

166-166: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

167-167: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

168-168: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

169-169: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

170-170: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

171-171: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

172-172: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

173-173: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

174-174: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

175-175: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

176-176: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

177-177: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

178-178: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

179-179: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

180-180: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

181-181: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

182-182: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

183-183: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

184-184: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

185-185: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

186-186: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

187-187: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

188-188: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

192-192: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

193-193: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

194-194: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

195-195: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

196-196: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

197-197: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

198-198: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

199-199: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

200-200: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

201-201: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

202-202: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

203-203: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

204-204: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

205-205: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

206-206: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

207-207: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

211-211: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

212-212: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

213-213: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

214-214: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

215-215: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

216-216: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

217-217: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

218-218: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

222-222: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

223-223: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

224-224: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

225-225: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

226-226: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

227-227: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

228-228: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

229-229: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

230-230: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

231-231: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

232-232: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

233-233: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

239-239: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

240-240: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

241-241: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

242-242: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

243-243: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

244-244: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

245-245: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

246-246: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

254-254: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

255-255: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

256-256: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

260-260: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

261-261: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

262-262: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

263-263: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

264-264: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

265-265: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

266-266: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

274-274: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

282-282: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

286-286: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

287-287: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

288-288: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

296-296: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

300-300: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

301-301: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

302-302: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

310-310: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

318-318: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

326-326: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

327-327: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

336-336: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

344-344: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

352-352: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

360-360: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

361-361: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

362-362: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

363-363: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

371-371: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

379-379: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

380-380: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

388-388: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

392-392: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

393-393: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

394-394: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

402-402: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

414-414: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

415-415: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

416-416: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

417-417: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

418-418: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

419-419: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

420-420: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

424-424: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

425-425: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

426-426: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

430-430: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

431-431: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

432-432: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

433-433: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

434-434: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

435-435: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

443-443: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

451-451: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

452-452: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

453-453: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

454-454: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

455-455: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

456-456: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

460-460: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

461-461: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

462-462: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

463-463: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

471-471: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

472-472: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

473-473: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

474-474: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

475-475: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

476-476: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

477-477: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

478-478: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

479-479: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

480-480: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

481-481: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

482-482: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

486-486: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

487-487: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

488-488: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

489-489: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

490-490: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

494-494: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

495-495: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

496-496: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

497-497: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

498-498: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

499-499: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

500-500: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

501-501: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

509-509: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

510-510: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

518-518: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

526-526: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

527-527: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

528-528: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

532-532: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

533-533: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

541-541: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

542-542: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

543-543: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

544-544: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

545-545: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

553-553: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

557-557: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

558-558: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

559-559: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

560-560: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

570-570: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

574-574: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

575-575: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

576-576: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

577-577: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

581-581: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

582-582: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

593-593: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

594-594: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

595-595: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

596-596: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

597-597: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

601-601: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

602-602: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

603-603: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

613-613: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

614-614: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

625-625: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

629-629: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

630-630: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

631-631: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

632-632: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

633-633: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

634-634: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

636-636: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

637-637: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

645-645: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

649-649: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

653-653: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

663-663: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

664-664: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

665-665: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

666-666: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

672-672: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

673-673: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

677-677: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

35-35: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

43-43: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

55-55: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

63-63: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

71-71: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

79-79: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

93-93: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

111-111: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

145-145: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

158-158: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

248-248: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

268-268: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

276-276: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

290-290: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

304-304: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

312-312: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

320-320: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

330-330: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

338-338: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

346-346: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

354-354: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

365-365: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

373-373: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

382-382: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

396-396: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

404-404: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

408-408: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

437-437: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

445-445: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

465-465: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

503-503: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

512-512: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

520-520: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

535-535: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

547-547: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

562-562: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

584-584: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

605-605: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

616-616: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

639-639: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

655-655: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

Additional comments not posted (4)
gomod2nix.toml (1)

265-266: Updated version and hash for "github.com/evmos/ethermint" module are correctly formatted and follow the expected conventions.

CHANGELOG.md (1)

28-28: Ensure the description of the fix in the CHANGELOG is detailed enough to understand the impact and scope of the change.

Verification successful

The description in the CHANGELOG is consistent with the detailed summary provided in the PR description.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the detailed description of the fix in the PR linked in the CHANGELOG.

# Test: Fetch the PR description and compare it with the CHANGELOG entry.
curl -s https://api.github.com/repos/crypto-org-chain/cronos/pulls/1466 | jq '.body'

Length of output: 2575

app/app.go (2)

1291-1298: Review the use of pendingTxListeners in CheckTx.

The implementation correctly notifies all registered listeners when a new transaction is checked and is valid. Ensure that all listeners are designed to handle being called from this context.

1286-1298: Verify integration of new transaction handling features.

Ensure that the new transaction handling features integrate seamlessly with the existing functionalities and do not introduce any side effects.

Verification successful

The output from the script shows that the CheckTx and RegisterPendingTxListener functions are primarily located in app/app.go. There are also references to CheckTx in other files like grpc_query.go, block_address.go, and bench_test.go.

To ensure that the new transaction handling features integrate seamlessly and do not introduce any side effects, we need to verify the following:

  1. The correct invocation of RegisterPendingTxListener.
  2. The proper handling of CheckTx in different contexts.
  3. Ensure that the new listener mechanism does not interfere with existing functionalities.

Let's generate additional scripts to gather more information about these aspects.

The results from the shell scripts indicate the following:

  1. Invocation of RegisterPendingTxListener:

    • The function RegisterPendingTxListener is defined in app/app.go and is not invoked anywhere else in the codebase. This suggests that it might be intended for future use or external invocation.

  2. Usage of CheckTx:

    • The CheckTx function is used in app/app.go, grpc_query.go, block_address.go, and bench_test.go. This indicates that CheckTx is a critical function used in various parts of the application, including tests.

  3. Handling of pendingTxListeners:

    • The pendingTxListeners slice is defined and used within app/app.go. It is appended to in RegisterPendingTxListener and iterated over in CheckTx.

Given this information, the new transaction handling features seem to be integrated correctly without interfering with existing functionalities. The pendingTxListeners mechanism is self-contained within app/app.go and does not appear to disrupt other parts of the codebase.

Therefore, the review comment is verified as correct, and no issues were found with the integration of the new features.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the integration of the new transaction handling features with existing functionalities.

# Test: Search for modifications in related transaction handling areas. Expect: No unexpected changes.
rg --type go 'CheckTx|RegisterPendingTxListener'

Length of output: 1006

Script:

#!/bin/bash
# Description: Verify the integration of the new transaction handling features with existing functionalities.

# Test 1: Check where RegisterPendingTxListener is invoked.
rg 'RegisterPendingTxListener' --type go

# Test 2: Check the usage of CheckTx in different contexts.
rg 'CheckTx' --type go

# Test 3: Ensure that the new listener mechanism does not interfere with existing functionalities.
# Specifically, we will look for any changes in the handling of transactions and listeners.
rg 'pendingTxListeners' --type go

Length of output: 1365

app/app.go Show resolved Hide resolved
app/app.go Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jun 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.85%. Comparing base (d41d670) to head (0955f82).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1466       +/-   ##
===========================================
+ Coverage   17.54%   35.85%   +18.31%     
===========================================
  Files          87      136       +49     
  Lines        5273     9806     +4533     
===========================================
+ Hits          925     3516     +2591     
- Misses       4238     5894     +1656     
- Partials      110      396      +286

see 72 files with indirect coverage changes

@mmsqe mmsqe added this pull request to the merge queue Jun 7, 2024
Merged via the queue into crypto-org-chain:main with commit 91936e4 Jun 7, 2024
37 checks passed
alienc0der pushed a commit to alienc0der/supernova that referenced this pull request Jun 8, 2024
@mmsqe @alienc0der
Problem: pending tx comes after get mined (crypto-org-chain#1466)
754e11a
This was referenced Jul 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai coderabbitai left review comments

@yihuang yihuang yihuang approved these changes

@JayT106 JayT106 Awaiting requested review from JayT106 JayT106 is a code owner automatically assigned from crypto-org-chain/cronos-dev

@thomas-nguy thomas-nguy Awaiting requested review from thomas-nguy thomas-nguy is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmsqe @yihuang