This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem: (CRO-622) Raw call function of WebsocketRpcClient cannot be accessed from other crates #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…accessed from other crates Solution: Made `call` and `call_batch` functions `pub`
devashishdxt
requested review from
yihuang,
tomtau,
calvinaco,
leejw51crypto,
lezzokafka and
linfeng-crypto
tomtau
approved these changes
Dec 5, 2019
There was a problem hiding this comment.
lgtm -- @devashishdxt I guess this is needed for the faucet / explorer?
|
bors r+ |
Yes. |
yihuang
approved these changes
Dec 5, 2019
bors bot
added a commit
that referenced
this pull request
Dec 5, 2019
655: Problem: no place to record and discuss high level architectural decisions r=tomtau a=tomtau Solution: added Architectural Decision Record template + readme 656: Problem: (CRO-622) Raw call function of WebsocketRpcClient cannot be accessed from other crates r=tomtau a=devashishdxt Solution: Made `call` and `call_batch` functions `pub` Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com> Co-authored-by: Devashish Dixit <devashish@crypto.com>
Build failed (retrying...) |
Codecov Report
@@ Coverage Diff @@
## master #656 +/- ##
======================================
Coverage 70.9% 70.9%
======================================
Files 133 133
Lines 16197 16197
======================================
Hits 11484 11484
Misses 4713 4713
|
Merge conflict (retrying...) |
bors bot
added a commit
that referenced
this pull request
Feb 2, 2021
2484: Bump cbindgen from 0.16.0 to 0.17.0 r=tomtau a=dependabot-preview[bot] Bumps [cbindgen](https://github.com/eqrion/cbindgen) from 0.16.0 to 0.17.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/eqrion/cbindgen/releases">cbindgen's releases</a>.</em></p> <blockquote> <h2>v0.17.0</h2> <ul> <li>Add with_parse_extra_bindings to builder. (<a href="https://github-redirect.dependabot.com/eqrion/cbindgen/issues/645">#645</a>)</li> <li>Support NonZero and fix incorrect simplification of Option<!-- raw HTML omitted --> into ptr. (<a href="https://github-redirect.dependabot.com/eqrion/cbindgen/issues/647">#647</a>)</li> <li>Deal with name conflicts correctly in declaration type resolution. (<a href="https://github-redirect.dependabot.com/eqrion/cbindgen/issues/651">#651</a>)</li> <li>Support pointers to ZSTs. (<a href="https://github-redirect.dependabot.com/eqrion/cbindgen/issues/656">#656</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/eqrion/cbindgen/blob/master/CHANGES">cbindgen's changelog</a>.</em></p> <blockquote> <h2>0.17.0</h2> <pre><code> * Add with_parse_extra_bindings to builder. ([#645](mozilla/cbindgen#645)) * Support NonZero and fix incorrect simplification of Option<ptr> into ptr. ([#647](mozilla/cbindgen#647)) * Deal with name conflicts correctly in declaration type resolution. ([#651](mozilla/cbindgen#651)) * Support pointers to ZSTs. ([#656](mozilla/cbindgen#656)) </code></pre> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/eqrion/cbindgen/commit/8236c8267936ae66785cd236c9c119c2f5b95b57"><code>8236c82</code></a> v0.17.0</li> <li><a href="https://github.com/eqrion/cbindgen/commit/3d41d33ffe1b1f811a5e3e3a8a077b8ec7464150"><code>3d41d33</code></a> config: Deal with clippy lints -.-.</li> <li><a href="https://github.com/eqrion/cbindgen/commit/c5c301b08a6a604d15e4ac6f18cb4ad5a916b4f1"><code>c5c301b</code></a> ir: Support pointers to zsts.</li> <li><a href="https://github.com/eqrion/cbindgen/commit/d3cd22bc6f07ccb595b8b82c8765f9023f2ffcc1"><code>d3cd22b</code></a> doc: Document the <code>documentation</code> config entry.</li> <li><a href="https://github.com/eqrion/cbindgen/commit/d0d287f9f32f4b64017250c0054e2637befa1075"><code>d0d287f</code></a> parser: Deal with a new clippy warning.</li> <li><a href="https://github.com/eqrion/cbindgen/commit/750745831af8755790a42f199b7733b37a3d9e0d"><code>7507458</code></a> ir: Deal with name conflicts correctly in declaration type resolution.</li> <li><a href="https://github.com/eqrion/cbindgen/commit/c47ee1516be72f4278b2c5e6b64a1e1edad13faf"><code>c47ee15</code></a> ir: Handle NonZero and simplify Option<NonZero> like we simplify Option<NonNu...</li> <li><a href="https://github.com/eqrion/cbindgen/commit/f922f68531fa44708af7779ffbb4b118d6e189ae"><code>f922f68</code></a> ir: Avoid generating bogus pointer arguments.</li> <li><a href="https://github.com/eqrion/cbindgen/commit/4ba7d1f0833b2c09b1c77a3012460c937b414f52"><code>4ba7d1f</code></a> ir: Make simplify_standard_types less clone-happy.</li> <li><a href="https://github.com/eqrion/cbindgen/commit/2e1be241671a356516cf8c910ba40c014c7b3144"><code>2e1be24</code></a> ir: Give integers a more structured representation.</li> <li>Additional commits viewable in <a href="https://github.com/eqrion/cbindgen/compare/v0.16.0...v0.17.0">compare view</a></li> </ul> </details> <br /> [](https://dependabot.com/compatibility-score/?dependency-name=cbindgen&package-manager=cargo&previous-version=0.16.0&new-version=0.17.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
bors bot
added a commit
that referenced
this pull request
Feb 2, 2021
2484: Bump cbindgen from 0.16.0 to 0.17.0 r=tomtau a=dependabot-preview[bot] Bumps [cbindgen](https://github.com/eqrion/cbindgen) from 0.16.0 to 0.17.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/eqrion/cbindgen/releases">cbindgen's releases</a>.</em></p> <blockquote> <h2>v0.17.0</h2> <ul> <li>Add with_parse_extra_bindings to builder. (<a href="https://github-redirect.dependabot.com/eqrion/cbindgen/issues/645">#645</a>)</li> <li>Support NonZero and fix incorrect simplification of Option<!-- raw HTML omitted --> into ptr. (<a href="https://github-redirect.dependabot.com/eqrion/cbindgen/issues/647">#647</a>)</li> <li>Deal with name conflicts correctly in declaration type resolution. (<a href="https://github-redirect.dependabot.com/eqrion/cbindgen/issues/651">#651</a>)</li> <li>Support pointers to ZSTs. (<a href="https://github-redirect.dependabot.com/eqrion/cbindgen/issues/656">#656</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/eqrion/cbindgen/blob/master/CHANGES">cbindgen's changelog</a>.</em></p> <blockquote> <h2>0.17.0</h2> <pre><code> * Add with_parse_extra_bindings to builder. ([#645](mozilla/cbindgen#645)) * Support NonZero and fix incorrect simplification of Option<ptr> into ptr. ([#647](mozilla/cbindgen#647)) * Deal with name conflicts correctly in declaration type resolution. ([#651](mozilla/cbindgen#651)) * Support pointers to ZSTs. ([#656](mozilla/cbindgen#656)) </code></pre> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/eqrion/cbindgen/commit/8236c8267936ae66785cd236c9c119c2f5b95b57"><code>8236c82</code></a> v0.17.0</li> <li><a href="https://github.com/eqrion/cbindgen/commit/3d41d33ffe1b1f811a5e3e3a8a077b8ec7464150"><code>3d41d33</code></a> config: Deal with clippy lints -.-.</li> <li><a href="https://github.com/eqrion/cbindgen/commit/c5c301b08a6a604d15e4ac6f18cb4ad5a916b4f1"><code>c5c301b</code></a> ir: Support pointers to zsts.</li> <li><a href="https://github.com/eqrion/cbindgen/commit/d3cd22bc6f07ccb595b8b82c8765f9023f2ffcc1"><code>d3cd22b</code></a> doc: Document the <code>documentation</code> config entry.</li> <li><a href="https://github.com/eqrion/cbindgen/commit/d0d287f9f32f4b64017250c0054e2637befa1075"><code>d0d287f</code></a> parser: Deal with a new clippy warning.</li> <li><a href="https://github.com/eqrion/cbindgen/commit/750745831af8755790a42f199b7733b37a3d9e0d"><code>7507458</code></a> ir: Deal with name conflicts correctly in declaration type resolution.</li> <li><a href="https://github.com/eqrion/cbindgen/commit/c47ee1516be72f4278b2c5e6b64a1e1edad13faf"><code>c47ee15</code></a> ir: Handle NonZero and simplify Option<NonZero> like we simplify Option<NonNu...</li> <li><a href="https://github.com/eqrion/cbindgen/commit/f922f68531fa44708af7779ffbb4b118d6e189ae"><code>f922f68</code></a> ir: Avoid generating bogus pointer arguments.</li> <li><a href="https://github.com/eqrion/cbindgen/commit/4ba7d1f0833b2c09b1c77a3012460c937b414f52"><code>4ba7d1f</code></a> ir: Make simplify_standard_types less clone-happy.</li> <li><a href="https://github.com/eqrion/cbindgen/commit/2e1be241671a356516cf8c910ba40c014c7b3144"><code>2e1be24</code></a> ir: Give integers a more structured representation.</li> <li>Additional commits viewable in <a href="https://github.com/eqrion/cbindgen/compare/v0.16.0...v0.17.0">compare view</a></li> </ul> </details> <br /> [](https://dependabot.com/compatibility-score/?dependency-name=cbindgen&package-manager=cargo&previous-version=0.16.0&new-version=0.17.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Made
callandcall_batchfunctionspub