This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem: no place to record and discuss high level architectural decisions #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sions Solution: added Architectural Decision Record template + readme
tomtau
requested review from
leejw51crypto,
lezzokafka,
linfeng-crypto and
yihuang
yihuang
approved these changes
Dec 5, 2019
lezzokafka
approved these changes
Dec 5, 2019
|
bors r+ |
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
======================================
Coverage 70.9% 70.9%
======================================
Files 133 133
Lines 16197 16197
======================================
Hits 11484 11484
Misses 4713 4713 |
bors bot
added a commit
that referenced
this pull request
Dec 5, 2019
655: Problem: no place to record and discuss high level architectural decisions r=tomtau a=tomtau Solution: added Architectural Decision Record template + readme 656: Problem: (CRO-622) Raw call function of WebsocketRpcClient cannot be accessed from other crates r=tomtau a=devashishdxt Solution: Made `call` and `call_batch` functions `pub` Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com> Co-authored-by: Devashish Dixit <devashish@crypto.com>
Build failed (retrying...) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: added Architectural Decision Record template + readme