Monkey Patch for support target_dir. #340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just an adhoc solution for issue cross-rs#272 Possble improvement: read `.cargo/config` to get target-dir.
xiaoniu-578fa6bff964d005
requested review from
Dylan-DPC-zz and
a team
as code owners
reitermarkus
requested changes
Nov 4, 2019
| @@ -8,12 +8,14 @@ pub struct Args { | |||
| pub all: Vec<String>, | |||
| pub subcommand: Option<Subcommand>, | |||
| pub target: Option<Target>, | |||
| pub target_dir: Option<String>, | |||
| } else if !arg.starts_with('-') && sc.is_none() { | ||
| sc = Some(Subcommand::from(&**arg)); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // delete target-dir from args.all | ||
| if let Some(ind) = all.iter().position(|x| x=="--target-dir") { | ||
| all[ind]=String::new(); |
There was a problem hiding this comment.
Call all.remove(ind) to remove the item.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an adhoc solution for issue #272
Possble improvement: read
.cargo/configto get target-dir.