Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross build --target-dir=<path> ... doesn't work #272

Closed
vadimcn opened this issue May 23, 2019 · 1 comment
Closed

cross build --target-dir=<path> ... doesn't work #272

vadimcn opened this issue May 23, 2019 · 1 comment
Labels

Comments

@vadimcn
Copy link

vadimcn commented May 23, 2019

I'm calling cross from cmake to build a Rust component, and I wanted to relocate the target directory under cmake's build root. Unfortunately, this does not work, because cross seems to assume that target must always be located next to Cargo.toml.

Relocating target via .cargo/config containing target-dir = "build/target" doesn't work either.

@vadimcn vadimcn changed the title cross --target-dir=<path> doesn't work cross build --target-dir=<path> ... doesn't work May 23, 2019
xiaoniu-578fa6bff964d005 added a commit to xiaoniu-578fa6bff964d005/cross that referenced this issue Nov 4, 2019
This is just an adhoc solution for issue cross-rs#272
Possble improvement: read `.cargo/config` to get target-dir.
@Alexhuszagh
Copy link
Contributor

Alexhuszagh commented May 26, 2022

This should have been patched as of #713, to ensure --target-dir works if passed into the container, or use the initial arguments if we fallback to the host. Let me know if the issue still remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants