Clarify behavior on superseded .NET minor version #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former implementation of the `install_required?` helper was meant to avoid non-idempotent behavior when a more recent .NET minor version is already present. There was ambiguity due to the name of the helper and the value of the log sent in case it returned `false`. As discussed in #55, I renamed the helper and reversed the logic to clarify the behavior. The log message is also updated.
Annih
force-pushed
the
superseded_net_version
branch
from
4245f00
to
36e8a94
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former implementation of the
install_required?helper was meantto avoid non-idempotent behavior when a more recent .NET minor version
is already present.
There was ambiguity due to the name of the helper and the value of the
log sent in case it returned
false.As discussed in #55, I renamed the helper and reversed the logic to
clarify the behavior. The log message is also updated.
Cc: @aboten