-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.2.1 not idempotent on Windows 7 sp1 #55
Comments
|
Hello @jugatsu Thanks for reporting this issue and giving us your feedback. I would like to clarify certain things before giving you answers.
Regards :) |
1a. attributes:
recipe:
2a. I think https://github.com/criteo-cookbooks/ms_dotnet/blob/master/resources/framework.rb#L119 always returns |
Ok I'll try to explain my point of view, because I wrote this logic :D ExplanationsFirst, let's talk about the
On the other hand At last, about the non-desired
ProposalsThe following proposals are not mutually exclusives.
Is it OK for you @jugatsu? :) |
The former implementation of the `install_required?` helper was meant to avoid non-idempotent behavior when a more recent .NET minor version is already present. There was ambiguity due to the name of the helper and the value of the log sent in case it returned `false`. As discussed in #55, I renamed the helper and reversed the logic to clarify the behavior. The log message is also updated.
The former implementation of the `install_required?` helper was meant to avoid non-idempotent behavior when a more recent .NET minor version is already present. There was ambiguity due to the name of the helper and the value of the log sent in case it returned `false`. As discussed in #55, I renamed the helper and reversed the logic to clarify the behavior. The log message is also updated.
@Annih I really appreciate your answer. Right now i'm good with setting |
The ms_dotnet_reboot is not intended to be used by external cookbooks. It performs reboot on notification only if a reboot is pending. Fix #55
The ms_dotnet_reboot is not intended to be used by external cookbooks. It performs reboot on notification only if a reboot is pending. Fix #55
The ms_dotnet_reboot is not intended to be used by external cookbooks. It performs reboot on notification only if a reboot is pending. Fix #55
The ms_dotnet_reboot is not intended to be used by external cookbooks. It performs reboot on notification only if a reboot is pending. Fix #55
install_required?
is alwaystrue
and it never printsAs a side effect if
reboot_pending?
is alsotrue
andperfrom_reboot
attribute istrue
then the node will be rebooted.v3.2.0 with #52 patch works as expected.
I think the cause of this behavior in f585848#diff-a7d2eeb2d086b81cd0d199ea024b68e3
The text was updated successfully, but these errors were encountered: