Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: bulk issuance upload issue #548

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

nishad-ayanworks
Copy link
Contributor

What

  • Worked on the error response handling in the bulk issuance upload

Signed-off-by: Nishad <nishad.shirsat@ayanworks.com>
Signed-off-by: Nishad <nishad.shirsat@ayanworks.com>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@KulkarniShashank KulkarniShashank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@@ -704,6 +704,8 @@ const credefError = [];
try {
const schemaResponse: SchemaDetails = await this.issuanceRepository.getCredentialDefinitionDetails(credentialDefinitionId);

// console.log(`Export CSV`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove commented code

@KulkarniShashank KulkarniShashank merged commit 3d8ba1f into develop Feb 27, 2024
2 checks passed
@nishad-ayanworks nishad-ayanworks deleted the fix-bulk-issuance-upload branch March 7, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants