Merge pull request #548 from credebl/fix-bulk-issuance-upload

fixed: bulk issuance upload issue
credebl · Feb 27, 2024 · 3d8ba1f · 3d8ba1f
2 parents 39cf07e + 42f4289
commit 3d8ba1f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/apps/api-gateway/src/issuance/issuance.controller.ts b/apps/api-gateway/src/issuance/issuance.controller.ts
@@ -220,7 +220,6 @@ export class IssuanceController {
     @Param('orgId') orgId: string,
     @Res() res: Response
   ): Promise<object> {
-    try {
 
       if (file) {
         const fileKey: string = uuidv4();
@@ -244,9 +243,7 @@ export class IssuanceController {
         };
         return res.status(HttpStatus.CREATED).json(finalResponse);
       }
-    } catch (error) {
-      throw new RpcException(error.response ? error.response : error);
-    }
+
   }
 
   @Get('/orgs/:orgId/:requestId/preview')

diff --git a/apps/issuance/src/issuance.service.ts b/apps/issuance/src/issuance.service.ts
@@ -710,7 +710,7 @@ const credefError = [];
   async exportSchemaToCSV(credentialDefinitionId: string): Promise<object> {
     try {
       const schemaResponse: SchemaDetails = await this.issuanceRepository.getCredentialDefinitionDetails(credentialDefinitionId);
-
+      
       const jsonData = [];
       const attributesArray = JSON.parse(schemaResponse.attributes);
 
@@ -822,11 +822,8 @@ const credefError = [];
 
     } catch (error) {
       this.logger.error(`error in validating credentials : ${error.response}`);
-      throw  new Error(error.response.message ? error.response.message : error);
-    } finally {
-      // await this.awsService.deleteFile(importFileDetails.fileKey);
-      // this.logger.error(`Deleted uploaded file after processing.`);
-    }
+      throw  new RpcException(error.response ? error.response : error);
+    } 
   }
 
   async previewFileDataForIssuance(