fix vendoring with go mod vendor
#88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A directory with a single C file in it will not be vendored by `go mod vendor`. This commits adds a workaround by putting dummy Go files which makes go mod behave correctly.
|
Thanks for catching this. So according to that issue its a no-no to put those C files in a sub-directory because if they change it won't trigger a rebuild. This is a bit of a dilemma because compilation time is super slow and I moved the files there to allow for two different compilation modes: static and linked. I may need to rethink my approach in light of this detail. In any case I think this is a decent solution. I need to test it still but I would also like to see comments added to the dummy.go files that explain what purpose they are serving. |
|
Looks good. Once I test it I'll get this merged. |
|
Thanks ! |
nwidger
pushed a commit
to nwidger/golua
that referenced
this pull request
Jul 22, 2020
A directory with only C files will not be vendored by go mod vendor, see this issue: golang/go#26366, specifically, Russ Cox's response golang/go#26366 (comment). Because of this, when vendoring github.com/aarzilli/golua with go mod vendor, the C header files under github.com/aarzilli/golua/lua/lua are not vendored. This commits adds a workaround to this issue by adding dummy Go files which makes go mod behave correctly. This workaround was based on a similar one found here: crawshaw/sqlite#88.
aarzilli
pushed a commit
to aarzilli/golua
that referenced
this pull request
Jul 30, 2020
A directory with only C files will not be vendored by go mod vendor, see this issue: golang/go#26366, specifically, Russ Cox's response golang/go#26366 (comment). Because of this, when vendoring github.com/aarzilli/golua with go mod vendor, the C header files under github.com/aarzilli/golua/lua/lua are not vendored. This commits adds a workaround to this issue by adding dummy Go files which makes go mod behave correctly. This workaround was based on a similar one found here: crawshaw/sqlite#88.
aarzilli
pushed a commit
to aarzilli/golua
that referenced
this pull request
Jul 30, 2020
A directory with only C files will not be vendored by go mod vendor, see this issue: golang/go#26366, specifically, Russ Cox's response golang/go#26366 (comment). Because of this, when vendoring github.com/aarzilli/golua with go mod vendor, the C header files under github.com/aarzilli/golua/lua/lua are not vendored. This commits adds a workaround to this issue by adding dummy Go files which makes go mod behave correctly. This workaround was based on a similar one found here: crawshaw/sqlite#88.
aarzilli
pushed a commit
to aarzilli/golua
that referenced
this pull request
Jul 30, 2020
A directory with only C files will not be vendored by go mod vendor, see this issue: golang/go#26366, specifically, Russ Cox's response golang/go#26366 (comment). Because of this, when vendoring github.com/aarzilli/golua with go mod vendor, the C header files under github.com/aarzilli/golua/lua/lua are not vendored. This commits adds a workaround to this issue by adding dummy Go files which makes go mod behave correctly. This workaround was based on a similar one found here: crawshaw/sqlite#88.
This was referenced Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A directory with a single C file in it will not be vendored by
go mod vendor, see this issue.This commits adds a workaround by putting dummy Go files which makes go mod behave correctly.
It's not ideal but I don't see another way (other than requiring users to manually copy the file in their vendor directory).