Fix vendoring of package using go mod vendor #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A directory with only C files will not be vendored by go mod vendor, see this issue: golang/go#26366, specifically, Russ Cox's response golang/go#26366 (comment). Because of this, when vendoring github.com/aarzilli/golua with go mod vendor, the C header files under github.com/aarzilli/golua/lua/lua are not vendored. This commits adds a workaround to this issue by adding dummy Go files which makes go mod behave correctly. This workaround was based on a similar one found here: crawshaw/sqlite#88.
parkerroan
approved these changes
Jul 23, 2020
|
Thank you. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A directory with only C files will not be vendored by go mod vendor,
see this issue: golang/go#26366,
specifically, Russ Cox's response
golang/go#26366 (comment).
Because of this, when vendoring github.com/aarzilli/golua with go mod
vendor, the C header files under github.com/aarzilli/golua/lua/lua are
not vendored. This commits adds a workaround to this issue by adding
dummy Go files which makes go mod behave correctly. This workaround
was based on a similar one found here:
crawshaw/sqlite#88.