Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement R4RepositorySubjectProvider logic for managingOrganization and partOf. #589

Merged

Conversation

lukedegruchy
Copy link
Contributor

@lukedegruchy lukedegruchy commented Nov 15, 2024

  • Implement logic for Organization-based subjectIds, including managingOrganization and optionally partOf
  • Introduce new configuration for partOf: SubjectProviderOptions, captured by MeasureEvaluationOptions, to contain the partOf configuration, which is a boolean
  • New test class

Closes #587

…and partOf. Draft unit test class. No conditional logic for partOf yet.
Copy link

github-actions bot commented Nov 15, 2024

Formatting check succeeded!

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 89.09091% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.67%. Comparing base (38872a3) to head (a072b58).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...hir/cr/measure/r4/R4RepositorySubjectProvider.java 90.90% 1 Missing and 2 partials ⚠️
.../cqf/fhir/cr/measure/MeasureEvaluationOptions.java 66.66% 2 Missing ⚠️
.../measure/dstu3/Dstu3RepositorySubjectProvider.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #589      +/-   ##
============================================
+ Coverage     73.63%   73.67%   +0.03%     
  Complexity       19       19              
============================================
  Files           362      363       +1     
  Lines         18950    18983      +33     
  Branches       2539     2541       +2     
============================================
+ Hits          13954    13985      +31     
- Misses         3634     3635       +1     
- Partials       1362     1363       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

…ionOptions. Use conditional logic in R4RepositorySubjectProvider to choose whether to perform a chained partOf query.
@lukedegruchy lukedegruchy changed the title Implement R4RepositorySubjectProvider logic for managingOrganization … Implement R4RepositorySubjectProvider logic for managingOrganization and partOf. Nov 18, 2024
@lukedegruchy lukedegruchy marked this pull request as ready for review November 20, 2024 15:31
@Capt-Mac Capt-Mac merged commit 187daa0 into master Nov 20, 2024
8 checks passed
@Capt-Mac Capt-Mac deleted the ld-20241115-support-repositoryusubjectprovider-organization branch November 20, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support querying patient resources by managingOrganization and optionally partOf
2 participants