Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backstage review #1496

Merged
merged 5 commits into from
Feb 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/client/src/AppRouter.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ const MinimalTimerView = React.lazy(() => import('./features/viewers/minimal-tim
const ClockView = React.lazy(() => import('./features/viewers/clock/Clock'));
const Countdown = React.lazy(() => import('./features/viewers/countdown/Countdown'));

const Backstage = React.lazy(() => import('./features/viewers/backstage/Backstage'));
const Backstage = React.lazy(() => import('./views/backstage/Backstage'));
const Timeline = React.lazy(() => import('./views/timeline/TimelinePage'));
const Public = React.lazy(() => import('./features/viewers/public/Public'));
const Public = React.lazy(() => import('./views/public/Public'));
const Lower = React.lazy(() => import('./features/viewers/lower-thirds/LowerThird'));
const StudioClock = React.lazy(() => import('./features/viewers/studio/StudioClock'));
const ProjectInfo = React.lazy(() => import('./views/project-info/ProjectInfo'));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ $progress-bar-br: 3px;
border-radius: $progress-bar-br;
background-color: var(--timer-progress-bg-override, $viewer-card-bg-color);
overflow: clip;

&--hidden {
display: none;
}
}

.progress-bar__indicator {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,15 @@ import './ProgressBar.scss';
interface ProgressBarProps {
current: MaybeNumber;
duration: MaybeNumber;
hidden?: boolean;
className?: string;
}

export default function ProgressBar(props: ProgressBarProps) {
const { current, duration, hidden, className = '' } = props;
const { current, duration, className } = props;
const progress = getProgress(current, duration);

return (
<div className={`progress-bar__bg ${hidden ? 'progress-bar__bg--hidden' : ''} ${className}`}>
<div className={`progress-bar__bg ${className}`}>
<div className='progress-bar__indicator' style={{ width: `${progress}%` }} />
</div>
);
Expand Down
76 changes: 0 additions & 76 deletions apps/client/src/common/components/schedule/Schedule.scss

This file was deleted.

52 changes: 0 additions & 52 deletions apps/client/src/common/components/schedule/Schedule.tsx

This file was deleted.

102 changes: 0 additions & 102 deletions apps/client/src/common/components/schedule/ScheduleContext.tsx

This file was deleted.

43 changes: 0 additions & 43 deletions apps/client/src/common/components/schedule/ScheduleItem.tsx

This file was deleted.

23 changes: 0 additions & 23 deletions apps/client/src/common/components/schedule/ScheduleNav.tsx

This file was deleted.

2 changes: 1 addition & 1 deletion apps/client/src/common/components/state/Empty.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

.empty {
width: 100%;
opacity: 0.6;
opacity: 0.8;
}

.text {
Expand Down
6 changes: 4 additions & 2 deletions apps/client/src/common/components/state/Empty.tsx
Original file line number Diff line number Diff line change
@@ -1,18 +1,20 @@
import { CSSProperties } from 'react';

import EmptyImage from '../../../assets/images/empty.svg?react';
import { cx } from '../../utils/styleUtils';

import style from './Empty.module.scss';

interface EmptyProps {
text?: string;
style?: CSSProperties;
className?: string;
}

export default function Empty(props: EmptyProps) {
const { text, ...rest } = props;
const { text, className, ...rest } = props;
return (
<div className={style.emptyContainer} {...rest}>
<div className={cx([style.emptyContainer, className])} {...rest}>
<EmptyImage className={style.empty} />
{text && <span className={style.text}>{text}</span>}
</div>
Expand Down
Loading