Backstage review #1496
Backstage review #1496
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
cpvalente
force-pushed
the
backstage-review
branch
5 times, most recently
from
e9f0bde to
d91a379
Compare
| hasEvents && showNow ? '' : formatTime(runtime.plannedEnd, { format12: 'hh:mm a', format24: 'HH:mm' }); | ||
|
|
||
| let stageTimer = millisToString(time.current, { fallback: timerPlaceholderMin }); | ||
| stageTimer = removeLeadingZero(stageTimer); |
There was a problem hiding this comment.
We call this stage timer but don't follow the same commends that the stage timer dose eg show message/aux/external
might be ok...
There was a problem hiding this comment.
thats a good point
I think the showrunner may want the presenter to see different things now and then.
However, the crew backstage is mostly interested in how long its left for the next thing
However, this does not solve the case where the showrunner wants the people backstage to see an aux timer... Maybe we can take that another time once we have a clear use case?
There was a problem hiding this comment.
sounds good, but maybe just call it timer and not stage timer?
There was a problem hiding this comment.
sounds good, called it displayTimer
| <div className={cx(['event', 'now', blinkClass && 'blink'])}> | ||
| <TitleCard title={nowMain} secondary={nowSecondary} /> | ||
| <div className='timer-group'> | ||
| <div className='aux-timers'> |
There was a problem hiding this comment.
This has nothing to do with the actual aux timer right?
could it get a different name?
refactor: improve empty state refactor: review schedule design - fit as many elements as possible - expose cycle interval as an option - stabilise rundown reference - style tweaks
cpvalente
force-pushed
the
backstage-review
branch
from
357c3c1 to
09b35ca
Compare
cpvalente
force-pushed
the
backstage-review
branch
from
09b35ca to
24954fc
Compare
style review for backstage
improve schedule
I have also decided to remove the animation since it caused too large layout shifts
This may also mean we may be able to shake off motion as part of the chakra migration