Skip to content
This repository has been archived by the owner on Nov 2, 2021. It is now read-only.

Style: Dark mode for Essentials #1390

Merged

Conversation

SensehacK
Copy link
Contributor

@SensehacK SensehacK commented Apr 22, 2020

Description of PR
Bug fix of Dark mode for specific page.

Type of PR

  • Bugfix
  • New feature

Relevant Issues
Fixes #1385

Checklist

  • Compiles and passes lint tests
  • Properly formatted
  • Tested on desktop
  • Tested on phone

Screenshots

Screen Shot 2020-04-22 at 12 57 41 AM

@vercel
Copy link

vercel bot commented Apr 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/covid19india/covid19india-react/76rx1hsdi
✅ Preview: https://covid19india-react-git-fork-sensehack-fix-darkmode-essentials.covid19india.now.sh

@jeremyphilemon jeremyphilemon changed the title (style)DarkMode: Fixed #1385 Essentials Page. Style: Dark mode on essentials page. Apr 22, 2020
@jeremyphilemon jeremyphilemon changed the title Style: Dark mode on essentials page. Style: Dark mode for Essentials Apr 22, 2020
@jeremyphilemon
Copy link
Collaborator

@SensehacK Thanks for the PR, this looks good! I like how you've even turned the dark-mode colors into sass variables too :D

@SensehacK
Copy link
Contributor Author

@jeremyphilemon Thanks, I may refactor some of the variables as it would be easy going forward for project management. I'll raise a PR when I'm done with it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worse essential page on dark mode
2 participants